Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#400 frontend updates #407

Merged
merged 5 commits into from
Jun 13, 2023
Merged

#400 frontend updates #407

merged 5 commits into from
Jun 13, 2023

Conversation

aswallace
Copy link
Collaborator

@aswallace aswallace commented Jun 12, 2023

Fixes various bugs in #400

  • Metamine mobile view errors
    • The main cards now reuse the "push asset" module used for images on the homepage and image detail view
    • Fixed sponsor icons that were getting squashed on resize
  • Image search undefined total bug
  • Logo on explorer page

Other issues in #400 have already been addressed in other recent PRs (#391)

See #408 for bugs that were not covered by this PR

@aswallace aswallace self-assigned this Jun 12, 2023
@aswallace aswallace linked an issue Jun 12, 2023 that may be closed by this pull request
7 tasks
Copy link
Contributor

@tholulomo tholulomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aswallace aswallace merged commit 055ac5c into develop Jun 13, 2023
@aswallace aswallace deleted the #400_frontend_updates branch June 13, 2023 00:24
@tholulomo
Copy link
Contributor

@aswallace can we track the remaining bugs that are yet to be fixed on a different ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend Bug Fixes
2 participants