#416 bulk curation #420
Merged
#416 bulk curation #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckend server response
… its new endpoint
…416_Bulk_Curation
aswallace
reviewed
Jul 6, 2023
aswallace
reviewed
Jul 11, 2023
|
|
||
| if (curatedAlready) return next(errorWriter(req, 'This has already been curated', 'curateXlsxSpreadsheet', 409)); | ||
| if (curatedAlready) return next(errorWriter(req, 'This had been curated already', 'curateXlsxSpreadsheet', 409)); |
There was a problem hiding this comment.
I'm not sure if I agree with this change
There was a problem hiding this comment.
This serves as a safeguard to prevent pre-existing curated spreadsheet from undergoing further unnecessary curation.
There was a problem hiding this comment.
I agree with that part, I just meant the wording/phrasing change
There was a problem hiding this comment.
@aswallace DM me your suggestion for rephrasing and I'll update it in the next PR
…age total response bug on search and updated unit test
…bles required by the restful service
… ignore _MACOSX folders
…aterialsmine into #425_bulk_curation_ui
aswallace
approved these changes
Jul 19, 2023
| <md-tooltip md-direction="top">Comment</md-tooltip> | ||
| <md-icon>comment</md-icon> | ||
| </md-button> | ||
| <div :class="[isSmallTabView ? 'u_margin-top-small u_adjust-banner-text' : 'u--margin-neg','md-fab md-fab-top-right u_width--max u--shadow-none u--layout-flex u--layout-flex-justify-end u--b-rad']"> |
There was a problem hiding this comment.
Locally, for screens smaller than laptop the buttons cover the title
…ccessful submissions
#425 bulk curation UI
…mine into #416_Bulk_Curation
Resolve SDD form errors and add basic unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket seeks to enable bulk curation for the spreadsheet curation pathway
closes #416 , closes #425