Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: define asm SYSNUM_REG for all arch #6027

Open
abhinav92003 opened this issue May 4, 2023 · 0 comments
Open

Cleanup: define asm SYSNUM_REG for all arch #6027

abhinav92003 opened this issue May 4, 2023 · 0 comments

Comments

@abhinav92003
Copy link
Contributor

Reported by @shiptux in #6014 (comment):

The asm SYSNUM_REG constant is defined too broadly at

dynamorio/core/arch/asm_defines.asm

Line 163 in 6cb94a8

# define SYSNUM_REG w8
. It should be defined only for AArch64.

Further, we should define SYSNUM_REG for all envs and refactor existing asm code to use it.
@abhinav92003 abhinav92003 mentioned this issue May 4, 2023
Merged
shiptux added a commit to shiptux/dynamorio that referenced this issue May 4, 2023
@shiptux
i#6027: define w8 only for AArch64
70a2c38 
The asm SYSNUM_REG w8 currently defined too broady.
This commit move it only for AArch64

Issue: DynamoRIO#6027
@shiptux shiptux mentioned this issue May 4, 2023
Merged
shiptux added a commit that referenced this issue May 12, 2023
@shiptux
i#6027: define w8 only for AArch64 (#6028)
71cc824 
The asm SYSNUM_REG w8 is currently defined too broadly. 
This commit move it to only defined in AArch64

Issue: #6027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abhinav92003