i#2372: do not lose control in native_exec with default options #2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoqin
approved these changes
Apr 21, 2017
| "-no_early_inject -native_exec_list common.nativeexec -native_exec_retakeover" "") | ||
| torunonly(common.nativeexec_bindnow common.nativeexec common/nativeexec.c | ||
| torunonly(common.nativeexec_bindnow common.nativeexec common/nativeexec_exenative.c |
| -> 40 | ||
| calling loop_test | ||
| Not under DR! | ||
| all done |
There was a problem hiding this comment.
From the test, how do we know we regain control at some where? somewhere did not print "Not under DR"
It would better if we can print "Under DR" somewhere to show we regain the control.
There was a problem hiding this comment.
These tests have the entire exe run natively. I think there is a library here? It's supposed to be under DR? I can try to link the annotations into the library.
…mplicating injection
…tive-exec-lose-control
|
The appveyor failure is api.detach #2246. |
mikelui
pushed a commit
to VANDAL/dynamorio-sigil2
that referenced
this pull request
Apr 25, 2017
…moRIO#2380) Fixes a regression from d7c0a6f which erroneously removed the retaddr mangling unless -native_exec_retakeover was set. Augments the native_exec test with annotations so we can actually tell whether we lost control. Unfortunately we have to disable the nativeexec tests on clang due to i#1799. Fixes DynamoRIO#2372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression from d7c0a6f which erroneously removed the retaddr
changing unless -native_exec_retakeover was set.
Augments the native_exec test with annotations so we can actually tell
whether we lost control.
Fixes #2372