Revert "Revert (#2940)" #2973
Merged
Revert "Revert (#2940)" #2973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 48db566 which reverted the changes in PR DynamoRIO#2940. The changes pushed caused some apps to overflow the modidx field (issue DynamoRIO#2956). PR DynamoRIO#2969 increased the width of the modidx field. We can now safely revert the revert.
|
The failing Travis CI is due to an open issue (burst_threadfilter test failing with "Cannot correctly handle a received signal" #2941). |
|
Re-ran that build and now it's all green. |
derekbruening
approved these changes
Apr 29, 2018
derekbruening
added a commit
that referenced
this pull request
Mar 10, 2021
PR #2940 and #2973 added an offset field to drmodtrack for #2939, but they ifdef-ed the field in some places but not others, resulting in uninitialized output. Since it's already locked into the interface, we always set it to 0 here and include it in internal structures to fix the problem. Tested on drmodtrack-test where the fields were manually confirmed to no longer contain bogus values, and where the test doesn't fail when that masked this bug before. Issue: #2939, #4474, #4777 Fixes #4777
derekbruening
added a commit
that referenced
this pull request
Mar 10, 2021
PR #2940 and #2973 added an offset field to drmodtrack for #2939, but they ifdef-ed the field in some places but not others, resulting in uninitialized output. Since it's already locked into the interface, we always set it to 0 here and include it in internal structures to fix the problem. Tested on drmodtrack-test where the fields were manually confirmed to no longer contain bogus values, and where the test doesn't fail when that masked this bug before. Issue: #2939, #4474, #4777 Fixes #4777
derekbruening
added a commit
that referenced
this pull request
Mar 10, 2021
PR #2940 and #2973 added an offset field to drmodtrack for #2939, but they ifdef-ed the field in some places but not others, resulting in uninitialized output. Since it's already locked into the interface, we always set it to 0 here and include it in internal structures to fix the problem. Tested on drmodtrack-test where the fields were manually confirmed to no longer contain bogus values, and where the test doesn't fail when i#4474 adds a new field that shifts the test buffer to avoid the happens-to-match scenario that masked this bug in that test before. Issue: #2939, #4474, #4777 Fixes #4777
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 48db566 which
reverted the changes in PR #2940. The changes pushed caused some apps to
overflow the modidx field (issue #2956). PR #2969 increased the width of
the modidx field. We can now safely revert the revert.