Bridge testing gap on AArch64 #4474

derekbruening · 2020-10-06T02:39:27Z

I'm filing this to help organize and drive work to finish big missing pieces on AArch64 in the test suite. There are about 140 tests on x86 that are not ported to AArch64, resulting in a big gap in coverage. As we run larger A64 apps we're running into many bugs, at least some of which would have been caught and fixed much more easily on our test suite than on a large, complex, custom app.

Xref the old master porting issue #1569 for AArch64 (and i#1551 for ARM).

My main initial focus is drcachesim, and there we have two big drivers of missing tests:

11 tests missing because of toolchain linking issue AArch64 build failures with static DR #2007
4 tests missing because of lack of annotation support port annotation infrastructure to AArchXX #1672, but we don't really need annotations: we could tweak the test app

Adds custom annotation macro defines to enable building the client.annotation-concurrency executable and its shared library on AArchXX. Enables the 4 tests that require that executable, but do not need annotation support: tool.drcachesim.threads, tool.drcachesim.threads-with-config-file, tool.drcachesim.coherence, and tool.drcachesim.TLB-threads. Issue: #4474, #1672

Fixes failures to use the writable addresses when patching code on AArch64. Enables the 5 -satisfy_w_xor_x tests on AArch64. Issue: #4458, #4474 Fixes #4458

Fixes an error in the a64 assembly in the burst_traceopts test. The test is not yet officially enabled for a64 but that work will be done later and it seems worth fixing this error now. Issue: #4474

Adds client thread support to AArchXX. Implements dynamorio_clone for both ARM and AArch64 and adds necessary TLS swapping, including handling initial tpidr* values pointing at read-only memory. Ports the client.signal test's assembly to a64 and arm. Enables the client.signal test on aarchxx. The test covers the client thread support here, as well as general client signal handling and manipulating. Tested manually on arm with the #4522 fix. Issue: #4474, #4516, #4522 Fixes #4516

Fixes an error in the a64 assembly in the burst_traceopts test. The test is not yet officially enabled for a64 but that work will be done later and it seems worth fixing this error now. Issue: #4474

Adds client thread support to AArchXX. Implements dynamorio_clone for both ARM and AArch64 and adds necessary TLS swapping, including handling initial tpidr* values pointing at read-only memory. Ports the client.signal test's assembly to a64 and arm. Enables the client.signal test on aarchxx. The test covers the client thread support here, as well as general client signal handling and manipulating. Tested manually on arm with the #4522 fix. Issue: #4474, #4516, #4522 Fixes #4516

The api.startstop test was crashing previously, but one of the many recent fixes seems to have addressed that problem. It now runs to completion 1000x in a row on AArch64. Issue: #1578, #4474

Adds a preferred_base field to the module_data_t struct. There is no compatibility break as DR allocates all such structs. Adds a preferred_base field to the drmodtrack_info_t struct. There is no compatibility break as it has a struct_size field. Offline drmodtrack files do incur a version bump here, so an old reader will fail when reading a file with the new field. The field is set to a -1 sentinel to aid in determining whether a file has the field or not. This is also done here with the previously-added offset field. Adds some sanity checks to the corresponding tests. Fixes #4474

PR #2940 and #2973 added an offset field to drmodtrack for #2939, but they ifdef-ed the field in some places but not others, resulting in uninitialized output. Since it's already locked into the interface, we always set it to 0 here and include it in internal structures to fix the problem. Tested on drmodtrack-test where the fields were manually confirmed to no longer contain bogus values, and where the test doesn't fail when that masked this bug before. Issue: #2939, #4474, #4777 Fixes #4777

derekbruening · 2022-01-25T16:48:42Z

Users are hitting missing AArch64 features like client threads (#5293 => #4516) and thread-private caches (#4279 => #1884).

derekbruening · 2022-01-25T16:50:17Z

Hmm actually #4516 is supposedly fixed.

Our test machines now have a new-enough toolchain to get past a linking bug that blocked building and running a dozen drcachesim tests with statically-linked DR on AArch64. We enable them all here, which helps bridge the testing gap with x86. Issue: #2007, #4474 Fixes #2007

Issue: #4474

…6849) Issue: #4474

Issue: #4474

Port client.strace.c test to AARCH64. Issue: #4474

Port client.strace test to AARCH64. Issue: #4474

Port client.thread test to AARCH64. Issue: #4474

Port client.nudge_ex test to AARCH64. Issue: #4474

Port client.dr_options test to AARCH64. Issue: #4474

Port client.nudge_ex test to AARCH64. Issue: #4474

Port client.dr_options test to AARCH64. Issue: #4474

Port security-common.retexisting test to AArch64. Issue: #4474

Port security-common.selfmod2 test to AArch64. Issue: #4474

Port security-common.retexisting test to AArch64. Issue: #4474

Port security-common.selfmod2 test to AArch64. Issue: #4474

Port security-common.selfmod test to AArch64. Issue: #4474

Port security-common.selfmod test to AArch64. These tests will catch issues like #5771. Issue: #4474

derekbruening added Component-Tests OpSys-AArch64 labels Oct 6, 2020

This was referenced Oct 6, 2020

Bridge testing gap on AArch64 #4475

Closed

AArch64 build failures with static DR #2007

Closed

derekbruening mentioned this issue Oct 6, 2020

i#4474 A64 testing: Enable drcachesim thread tests #4476

Merged

derekbruening mentioned this issue Oct 8, 2020

i#4458: W^X on AArch64 #4482

Merged

derekbruening added a commit that referenced this issue Oct 8, 2020

i#4458: W^X on AArch64 (#4482)

1bc72b6

Fixes failures to use the writable addresses when patching code on AArch64. Enables the 5 -satisfy_w_xor_x tests on AArch64. Issue: #4458, #4474 Fixes #4458

derekbruening mentioned this issue Nov 4, 2020

i#4474 a64 tests: Fix a64 asm error in burst_traceopts #4515

Merged

derekbruening mentioned this issue Nov 4, 2020

AArch64 missing support for client threads #4516

Closed

derekbruening mentioned this issue Nov 5, 2020

i#4516: Add client thread support for AArchXX #4524

Merged

derekbruening mentioned this issue Jan 28, 2021

Port api.detach_state to aarch64 and fix any bugs it finds #4698

Open

derekbruening mentioned this issue Feb 5, 2021

i#1578,i#4474 arm detach: Enable api.startstop on arm #4715

Merged

This was referenced Feb 5, 2021

HANG api.static_prepop on aarch64 #4717

Closed

api.static_noclient test fails with assert on jenkins #4716

Closed

client.drwrap-test-detach fails 28/100 times on aarch64: hang #4718

Closed

support detach on 32-bit ARM (AArch64 finished) #1578

Open

This was referenced Mar 10, 2021

i#4774: Add preferred base to DR and drmodtrack interfaces #4775

Merged

drmodtrack offset field has uninitialized values on Windows #4777

Closed

AssadHashmi self-assigned this Jan 25, 2022

derekbruening mentioned this issue Feb 10, 2022

i#2007: Enable static dr$sim tests on AArch64 #5346

Merged

philramsey-arm added a commit that referenced this issue Jun 18, 2024

i#4474: Port client.flush and client.cbr-retarget tests to AARCH64

9db33a3

Issue: #4474

philramsey-arm mentioned this issue Jun 18, 2024

i#4474: Port client.flush and client.cbr-retarget tests to AARCH64 #6849

Merged

philramsey-arm added a commit that referenced this issue Jun 20, 2024

i#4474: Port client.flush and client.cbr-retarget tests to AARCH64 (#…

be86932

…6849) Issue: #4474

philramsey-arm added a commit that referenced this issue Jun 27, 2024

i#4474: Port client.thread test to AARCH64

9b7aa43

Issue: #4474

philramsey-arm mentioned this issue Jun 27, 2024

i#4474: Port client.thread test to AARCH64 #6858

Merged

philramsey-arm added a commit that referenced this issue Jul 1, 2024

i#4474: Port client.strace.c test to AARCH64

6bfcab3

Port client.strace.c test to AARCH64. Issue: #4474

philramsey-arm mentioned this issue Jul 1, 2024

i#4474: Port client.strace test to AARCH64 #6862

Merged

philramsey-arm added a commit that referenced this issue Jul 3, 2024

i#4474: Port client.strace test to AARCH64 (#6862)

bd49f81

Port client.strace test to AARCH64. Issue: #4474

philramsey-arm added a commit that referenced this issue Jul 3, 2024

i#4474: Port client.thread test to AARCH64 (#6858)

0f878da

Port client.thread test to AARCH64. Issue: #4474

philramsey-arm added a commit that referenced this issue Jul 4, 2024

i#4474: Port client.nudge_ex test to AARCH64

9d8a88e

Port client.nudge_ex test to AARCH64. Issue: #4474

philramsey-arm mentioned this issue Jul 4, 2024

i#4474: Port client.nudge_ex test to AARCH64 #6867

Merged

philramsey-arm added a commit that referenced this issue Jul 8, 2024

i#4474: Port client.dr_options test to AARCH64

bd64e42

Port client.dr_options test to AARCH64. Issue: #4474

philramsey-arm mentioned this issue Jul 8, 2024

i#4474: Port client.dr_options test to AARCH64 #6869

Merged

philramsey-arm added a commit that referenced this issue Jul 8, 2024

i#4474: Port client.nudge_ex test to AARCH64 (#6867)

8a766f4

Port client.nudge_ex test to AARCH64. Issue: #4474

philramsey-arm added a commit that referenced this issue Jul 10, 2024

i#4474: Port client.dr_options test to AARCH64 (#6869)

560092b

Port client.dr_options test to AARCH64. Issue: #4474

philramsey-arm added a commit that referenced this issue Jul 11, 2024

i#4474: Port security-common.retexisting test to AArch64

39283c5

Port security-common.retexisting test to AArch64. Issue: #4474

philramsey-arm mentioned this issue Jul 11, 2024

i#4474: Port security-common.retexisting test to AArch64 #6875

Merged

philramsey-arm added a commit that referenced this issue Jul 12, 2024

i#4474: Port security-common.selfmod2 test to AArch64

824a6ab

Port security-common.selfmod2 test to AArch64. Issue: #4474

philramsey-arm mentioned this issue Jul 12, 2024

i#4474: Port security-common.selfmod2 test to AArch64 #6876

Merged

philramsey-arm added a commit that referenced this issue Jul 12, 2024

i#4474: Port security-common.retexisting test to AArch64 (#6875)

fa2475b

Port security-common.retexisting test to AArch64. Issue: #4474

philramsey-arm added a commit that referenced this issue Jul 15, 2024

i#4474: Port security-common.selfmod2 test to AArch64 (#6876)

8742c85

Port security-common.selfmod2 test to AArch64. Issue: #4474

philramsey-arm added a commit that referenced this issue Aug 7, 2024

i#4474: Port security-common.selfmod test to AArch64

915866c

Port security-common.selfmod test to AArch64. Issue: #4474

philramsey-arm mentioned this issue Aug 7, 2024

i#4474: Port security-common.selfmod test to AArch64 #6908

Merged

philramsey-arm added a commit that referenced this issue Aug 21, 2024

i#4474: Port security-common.selfmod test to AArch64 (#6908)

d26a744

Port security-common.selfmod test to AArch64. These tests will catch issues like #5771. Issue: #4474

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bridge testing gap on AArch64 #4474

Bridge testing gap on AArch64 #4474

derekbruening commented Oct 6, 2020

derekbruening commented Jan 25, 2022

derekbruening commented Jan 25, 2022 •

edited

Loading

Bridge testing gap on AArch64 #4474

Bridge testing gap on AArch64 #4474

Comments

derekbruening commented Oct 6, 2020

derekbruening commented Jan 25, 2022

derekbruening commented Jan 25, 2022 • edited Loading

derekbruening commented Jan 25, 2022 •

edited

Loading