Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i#4474 a64 tests: Fix a64 asm error in burst_traceopts #4515

Merged
merged 1 commit into from
Nov 4, 2020
Merged

i#4474 a64 tests: Fix a64 asm error in burst_traceopts #4515

merged 1 commit into from
Nov 4, 2020

Conversation

derekbruening
Copy link
Contributor

Fixes an error in the a64 assembly in the burst_traceopts test. The
test is not yet officially enabled for a64 but that work will be done
later and it seems worth fixing this error now.

Issue: #4474

@derekbruening
i#4474 a64 tests: Fix a64 asm error in burst_traceopts
ddbdfbb 
Fixes an error in the a64 assembly in the burst_traceopts test.  The
test is not yet officially enabled for a64 but that work will be done
later and it seems worth fixing this error now.

Issue: #4474
@derekbruening
Copy link
Contributor Author

Appveyor failure is burst_static #4486 :

21601219:   <Application
21601219:   C:\projects\dynamorio\build\build_debug-internal-64\clients\bin64\tool.drcacheoff.burst_static.exe
21602219:   (5080).  Internal Error: DynamoRIO debug check failure:
21603219:   ..\..\core\win32\callback.c:1478 false

@derekbruening derekbruening merged commit c89aa68 into master Nov 4, 2020
@derekbruening derekbruening deleted the i4474-traceopts-asm-error branch November 4, 2020 14:15
fengjixuchui added a commit to fengjixuchui/dynamorio that referenced this pull request Nov 4, 2020
@fengjixuchui
Merge pull request #1 from DynamoRIO/master
a134e28 
i#4474 a64 tests: Fix a64 asm error in burst_traceopts (DynamoRIO#4515)
gregcawthorne pushed a commit that referenced this pull request Nov 28, 2020
@derekbruening @gregcawthorne
i#4474 a64 tests: Fix a64 asm error in burst_traceopts (#4515)
58fcefd 
Fixes an error in the a64 assembly in the burst_traceopts test.  The
test is not yet officially enabled for a64 but that work will be done
later and it seems worth fixing this error now.

Issue: #4474
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AssadHashmi AssadHashmi AssadHashmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derekbruening @AssadHashmi