i#4131: Set up Windows Github Actions #4586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds two separate jobs on Windows, 32-bit and 64-bit. We target a VS2017 Win10-1607 image to match what we had on Appveyor. Modifies the runsuite_wrapper.pl script to *not* fork, since there is no Cygwin perl available by default. Instead, we tee to a file. This is based on the similar work in progress for Dr. Memory: DynamoRIO/drmemory#23 Issue: #4131
…ums from wrappers
Uses the empirically-determined syscall numbers even for OS versions we have in our static table, for win10-1511+. We have seen variants that our current version logic is not aware of, and we're using the from-wrapper numbers on all very-recent versions anyway. Issue: #4587, DynamoRIO/drmemory#2328 Fixes #4587
Removes what was thought of as a sanity check for the allocation base changing in DR's internal query loop, but it turns out there are cases of anomalous bases for which failing the query has disastrous consequences. Just ignoring the anomaly and moving on is the solution. Tested on the Github Actions Windows Server 16 images. Issue: #4588, DynamoRIO/drmemory#2328 Fixes #4588
This reverts commit 9544382.
…thub-action-windows
This reverts commit 4a44bf6. It did not solve the failure.
This reverts commit 6930caf.
… the GA-failing tests and remove the i#4058 appveyor ones without their own issues in the hopes they are not flaky on GA
….cmake; re-instate 3 ignores on 32-bit
abhinav92003
approved these changes
Dec 15, 2020
| set PATH=c:\projects\install\doxygen;%PATH% | ||
| call "C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/VC/Auxiliary/Build/vcvars32.bat" | ||
| echo ------ Running suite ------ | ||
| echo PATH is "%PATH%" |
There was a problem hiding this comment.
These seem to be temporary debug statements. Perhaps they need to be removed?
There was a problem hiding this comment.
Sorry, just saw this after merging (took a while to edit the merge message). Yes, but it is very useful and doesn't take up much space and was in fact present in the Appveyor config the whole time as well. Could be removed but since it was there before I included it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two separate jobs on Windows, 32-bit and 64-bit.
We target a VS2017 Win10-1607 image to match what we had on Appveyor.
Modifies the runsuite_wrapper.pl script to not fork, since there is
no Cygwin perl available by default. Instead, we tee to a file.
This is based on the similar work in progress for Dr. Memory:
DynamoRIO/drmemory#2326
Issue: #4131