Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#4131: Set up Windows Github Actions #4586

Merged
merged 28 commits into from
Dec 15, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
1a80e83
i#4131: Set up Windows Github Actions
derekbruening Dec 5, 2020
04fe37a
TEMP: Remove appveyor config while testing
derekbruening Dec 5, 2020
9544382
TEMP: Remove other GA jobs while testing Windows
derekbruening Dec 5, 2020
070ed2d
Correct path to runsuite_wrapper.pl
derekbruening Dec 5, 2020
adf9ddc
Add diagnostics for syscall assert
derekbruening Dec 5, 2020
2f03cdb
Add error info for drx-test; could be kept permanently
derekbruening Dec 5, 2020
6930caf
TEMP diagnostics for decode tests
derekbruening Dec 5, 2020
4bb5502
Generalize api.symtest golden output to handle extra operators found
derekbruening Dec 5, 2020
157fa89
Remove diagnostics; impl i#4587 soln: for win10-1511+ always use sysn…
derekbruening Dec 6, 2020
4de05f0
symtest: escape brackets
derekbruening Dec 6, 2020
4a44bf6
Try backslashes in drx-test path
derekbruening Dec 6, 2020
85d34af
i#4587: Use from-wrapper syscall numbers for all win10 (#4589)
derekbruening Dec 6, 2020
cdaa8cf
i#4588: Handle anomalous alloc bases in Windows query loop (#4590)
derekbruening Dec 6, 2020
23dd14b
Revert "TEMP: Remove other GA jobs while testing Windows"
derekbruening Dec 14, 2020
940f847
Merge branch 'master' of github.com:DynamoRIO/dynamorio into i4131-gi…
derekbruening Dec 14, 2020
c4def79
Revert "Try backslashes in drx-test path"
derekbruening Dec 14, 2020
06edc61
Revert "TEMP diagnostics for decode tests"
derekbruening Dec 14, 2020
2f34484
Apply ignore list to native Windows perl and edit the list to include…
derekbruening Dec 14, 2020
6a24f6c
TEMPORARY re-remove the other workflows until windows is green
derekbruening Dec 14, 2020
592c8c3
Split non-test-running builds into a 3rd job via new args to runsuite…
derekbruening Dec 14, 2020
5cd17f3
Build job should be 32-bit and vps too; add 2 more 32-bit failures
derekbruening Dec 14, 2020
2e91c4d
i#4610: Fix VS2017 OOM by splitting avx512 test files
derekbruening Dec 14, 2020
05afc72
Remove APPVEYOR_PULL_REQUEST_NUMBER-driven build skips now that we ha…
derekbruening Dec 14, 2020
f60c8fe
Revert "TEMPORARY re-remove the other workflows until windows is green"
derekbruening Dec 15, 2020
f201450
Revert "TEMP: Remove appveyor config while testing"
derekbruening Dec 15, 2020
81f6e9d
Merge branch 'master' of github.com:DynamoRIO/dynamorio into i4131-gi…
derekbruening Dec 15, 2020
2c85e69
Clang-format windows-edited file
derekbruening Dec 15, 2020
f783893
Add win32.earlythread to the ignore list
derekbruening Dec 15, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
169 changes: 169 additions & 0 deletions .github/workflows/ci-windows.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,169 @@
# **********************************************************
# Copyright (c) 2020 Google, Inc. All rights reserved.
# **********************************************************

# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are met:
#
# * Redistributions of source code must retain the above copyright notice,
# this list of conditions and the following disclaimer.
#
# * Redistributions in binary form must reproduce the above copyright notice,
# this list of conditions and the following disclaimer in the documentation
# and/or other materials provided with the distribution.
#
# * Neither the name of Google, Inc. nor the names of its contributors may be
# used to endorse or promote products derived from this software without
# specific prior written permission.
#
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
# ARE DISCLAIMED. IN NO EVENT SHALL VMWARE, INC. OR CONTRIBUTORS BE LIABLE
# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
# LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
# OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
# DAMAGE.

# Github Actions workflow for Windows Continuous Integration testing.

# TODO i#2145: point at Qt5 for testing drgui build.

name: ci-windows
on:
# Run on pushes to master and on pull request changes, including from a
# forked repo with no "push" trigger, while avoiding duplicate triggers.
push:
branches:
- master
pull_request:
types: [opened, reopened, synchronize]

# Manual trigger using the Actions page. May remove when integration complete.
workflow_dispatch:

defaults:
run:
shell: cmd

jobs:
###########################################################################
# 32-bit VS2017 and tests:
vs2017-32:
runs-on: windows-2016

steps:
- uses: actions/checkout@v2

# Cancel any prior runs for a PR (but do not cancel master branch runs).
- uses: n1hility/cancel-previous-runs@v2
with:
token: ${{ secrets.GITHUB_TOKEN }}
if: ${{ github.event_name == 'pull_request' }}

- name: Fetch Sources
run: git fetch --no-tags --depth=1 origin master

- name: Download Packages
shell: powershell
run: |
md c:\projects\install
(New-Object System.Net.WebClient).DownloadFile("https://github.com/ninja-build/ninja/releases/download/v1.7.2/ninja-win.zip", "c:\projects\install\ninja.zip")
(New-Object System.Net.WebClient).DownloadFile("http://doxygen.nl/files/doxygen-1.8.19.windows.x64.bin.zip", "c:\projects\install\doxygen.zip")

- name: Run Suite
working-directory: ${{ github.workspace }}
run: |
echo ------ Setting up paths ------
7z x c:\projects\install\ninja.zip -oc:\projects\install\ninja > nul
set PATH=c:\projects\install\ninja;%PATH%
7z x c:\projects\install\doxygen.zip -oc:\projects\install\doxygen > nul
set PATH=c:\projects\install\doxygen;%PATH%
call "C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/VC/Auxiliary/Build/vcvars32.bat"
echo ------ Running suite ------
echo PATH is "%PATH%"
echo Running in directory "%CD%"
perl suite/runsuite_wrapper.pl travis use_ninja 32_only debug_only
env:
CI_TRIGGER: ${{ github.event_name }}

###########################################################################
# 64-bit VS2017 and tests:
vs2017-64:
runs-on: windows-2016

steps:
- uses: actions/checkout@v2

# Cancel any prior runs for a PR (but do not cancel master branch runs).
- uses: n1hility/cancel-previous-runs@v2
with:
token: ${{ secrets.GITHUB_TOKEN }}
if: ${{ github.event_name == 'pull_request' }}

- name: Fetch Sources
run: git fetch --no-tags --depth=1 origin master

- name: Download Packages
shell: powershell
run: |
md c:\projects\install
(New-Object System.Net.WebClient).DownloadFile("https://github.com/ninja-build/ninja/releases/download/v1.7.2/ninja-win.zip", "c:\projects\install\ninja.zip")
(New-Object System.Net.WebClient).DownloadFile("http://doxygen.nl/files/doxygen-1.8.19.windows.x64.bin.zip", "c:\projects\install\doxygen.zip")

- name: Run Suite
working-directory: ${{ github.workspace }}
run: |
echo ------ Setting up paths ------
7z x c:\projects\install\ninja.zip -oc:\projects\install\ninja > nul
set PATH=c:\projects\install\ninja;%PATH%
7z x c:\projects\install\doxygen.zip -oc:\projects\install\doxygen > nul
set PATH=c:\projects\install\doxygen;%PATH%
call "C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/VC/Auxiliary/Build/vcvars32.bat"
echo ------ Running suite ------
echo PATH is "%PATH%"
echo Running in directory "%CD%"
perl suite/runsuite_wrapper.pl travis use_ninja 64_only debug_only
env:
CI_TRIGGER: ${{ github.event_name }}

###########################################################################
# 32-bit and 64-bit VS2017 release builds plus a vps build:
vs2017-builds:
runs-on: windows-2016

steps:
- uses: actions/checkout@v2

# Cancel any prior runs for a PR (but do not cancel master branch runs).
- uses: n1hility/cancel-previous-runs@v2
with:
token: ${{ secrets.GITHUB_TOKEN }}
if: ${{ github.event_name == 'pull_request' }}

- name: Fetch Sources
run: git fetch --no-tags --depth=1 origin master

- name: Download Packages
shell: powershell
run: |
md c:\projects\install
(New-Object System.Net.WebClient).DownloadFile("https://github.com/ninja-build/ninja/releases/download/v1.7.2/ninja-win.zip", "c:\projects\install\ninja.zip")
(New-Object System.Net.WebClient).DownloadFile("http://doxygen.nl/files/doxygen-1.8.19.windows.x64.bin.zip", "c:\projects\install\doxygen.zip")

- name: Run Suite
working-directory: ${{ github.workspace }}
run: |
echo ------ Setting up paths ------
7z x c:\projects\install\ninja.zip -oc:\projects\install\ninja > nul
set PATH=c:\projects\install\ninja;%PATH%
7z x c:\projects\install\doxygen.zip -oc:\projects\install\doxygen > nul
set PATH=c:\projects\install\doxygen;%PATH%
call "C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/VC/Auxiliary/Build/vcvars32.bat"
echo ------ Running suite ------
echo PATH is "%PATH%"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem to be temporary debug statements. Perhaps they need to be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just saw this after merging (took a while to edit the merge message). Yes, but it is very useful and doesn't take up much space and was in fact present in the Appveyor config the whole time as well. Could be removed but since it was there before I included it here.

echo Running in directory "%CD%"
perl suite/runsuite_wrapper.pl travis use_ninja nontest_only
70 changes: 37 additions & 33 deletions suite/runsuite.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ set(arg_package OFF)
set(arg_require_format OFF)
set(cross_aarchxx_linux_only OFF)
set(cross_android_only OFF)
set(arg_debug_only OFF) # Only build the main debug builds.
set(arg_nontest_only OFF) # Only build configs with no tests.
foreach (arg ${CTEST_SCRIPT_ARG})
if (${arg} STREQUAL "travis")
set(arg_travis ON)
Expand All @@ -68,6 +70,10 @@ foreach (arg ${CTEST_SCRIPT_ARG})
set(arg_package ON)
elseif (${arg} STREQUAL "require_format")
set(arg_require_format ON)
elseif (${arg} STREQUAL "debug_only")
set(arg_debug_only ON)
elseif (${arg} STREQUAL "nontest_only")
set(arg_nontest_only ON)
endif ()
endforeach (arg)

Expand Down Expand Up @@ -115,13 +121,9 @@ else (TEST_LONG)
set(DO_ALL_BUILDS OFF)
endif (TEST_LONG)

# i#4059: Speed up Appveyor on PR's by not building 64-bit tests.
# We're only running tests on Travis.
if (DEFINED ENV{APPVEYOR_PULL_REQUEST_NUMBER})
set(build_release_tests "")
else ()
set(build_release_tests ${build_tests})
endif ()
# Now that we have a separate parallel job for release builds we always
# build all tests.
set(build_release_tests ${build_tests})

if (UNIX)
# For cross-arch execve tests we need to run from an install dir
Expand Down Expand Up @@ -294,24 +296,28 @@ endif ()

if (NOT cross_aarchxx_linux_only AND NOT cross_android_only AND NOT a64_on_x86_only)
# For cross-arch execve test we need to "make install"
testbuild_ex("debug-internal-32" OFF "
DEBUG:BOOL=ON
INTERNAL:BOOL=ON
${build_tests}
${install_path_cache}
" OFF ON "${install_build_args}")
if (NOT arg_nontest_only)
testbuild_ex("debug-internal-32" OFF "
DEBUG:BOOL=ON
INTERNAL:BOOL=ON
${build_tests}
${install_path_cache}
" OFF ON "${install_build_args}")
endif ()
if (last_build_dir MATCHES "-32")
set(32bit_path "TEST_32BIT_PATH:PATH=${last_build_dir}/suite/tests/bin")
else ()
set(32bit_path "")
endif ()
testbuild_ex("debug-internal-64" ON "
DEBUG:BOOL=ON
INTERNAL:BOOL=ON
${build_tests}
${install_path_cache}
${32bit_path}
" OFF ON "${install_build_args}")
if (NOT arg_nontest_only)
testbuild_ex("debug-internal-64" ON "
DEBUG:BOOL=ON
INTERNAL:BOOL=ON
${build_tests}
${install_path_cache}
${32bit_path}
" OFF ON "${install_build_args}")
endif ()
# we don't really support debug-external anymore
if (DO_ALL_BUILDS_NOT_SUPPORTED)
testbuild("debug-external-64" ON "
Expand All @@ -323,9 +329,7 @@ if (NOT cross_aarchxx_linux_only AND NOT cross_android_only AND NOT a64_on_x86_o
INTERNAL:BOOL=OFF
")
endif ()
# i#4059: We skip 32-bit release build in Appveyor PR's to speed things up.
# The 64-bit release should cover nearly all 32-bit release-only warnings.
if (NOT DEFINED ENV{APPVEYOR_PULL_REQUEST_NUMBER})
if (NOT arg_debug_only)
testbuild_ex("release-external-32" OFF "
DEBUG:BOOL=OFF
INTERNAL:BOOL=OFF
Expand All @@ -339,13 +343,15 @@ if (NOT cross_aarchxx_linux_only AND NOT cross_android_only AND NOT a64_on_x86_o
endif ()
set(orig_extra_ctest_args ${extra_ctest_args})
set(extra_ctest_args INCLUDE_LABEL RUN_IN_RELEASE)
testbuild_ex("release-external-64" ON "
DEBUG:BOOL=OFF
INTERNAL:BOOL=OFF
${build_release_tests}
${install_path_cache}
${32bit_path}
" OFF ${arg_package} "${install_build_args}")
if (NOT arg_debug_only)
testbuild_ex("release-external-64" ON "
DEBUG:BOOL=OFF
INTERNAL:BOOL=OFF
${build_release_tests}
${install_path_cache}
${32bit_path}
" OFF ${arg_package} "${install_build_args}")
endif ()
set(extra_ctest_args ${orig_extra_ctest_args})
if (DO_ALL_BUILDS)
# we rarely use internal release builds but keep them working in long
Expand Down Expand Up @@ -394,9 +400,7 @@ if (NOT cross_aarchxx_linux_only AND NOT cross_android_only AND NOT a64_on_x86_o
${install_path_cache}
")
endif (DO_ALL_BUILDS)
# i#2406: we skip the vps build to speed up PR's, using just the merge to
# master to catch breakage in vps.
if (NOT DEFINED ENV{APPVEYOR_PULL_REQUEST_NUMBER})
if (NOT arg_debug_only)
testbuild("vps-debug-internal-32" OFF "
VMAP:BOOL=OFF
VPS:BOOL=ON
Expand Down
Loading