i#4717: Fix hang in api.static_prepop test on aarchxx #4721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug in the api.static_prepop assembly where the link register is clobbered, leading to an infinite loop on aarchxx. Enables the test for aarchxx. Fixes a bug on identifying stopping points on ARM where LSB Thumb decoration on the two sides of the comparison was not consistent. Fixes a corresponding bug on going native where the LSB was not set. Tested manually on ARM. Issue: #1578, #4717, #4720 Fixes #4717
abhinav92003
approved these changes
Feb 5, 2021
|
Failure is the max-global: #4711. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the api.static_prepop assembly where the link register
is clobbered, leading to an infinite loop on aarchxx.
Enables the test for aarchxx.
Fixes a bug on identifying stopping points on ARM where LSB Thumb
decoration on the two sides of the comparison was not consistent.
Fixes a corresponding bug on going native where the LSB was not set.
Tested manually on ARM.
Issue: #1578, #4717, #4720
Fixes #4717