i#4393 AArch64 codec: Refactor fpimm8 codec #5820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many immediate value operands follow the naming convention: <type>imm<size>_<lsb> So you would expect fpimm13 to be a 13-bit floating-point immediate value. It is actually an 8-bit floating-point immediate value at bit 13 so following the above naming convention it should be called fpimm8_13. Issues: #4393
jackgallagher-arm
requested review from
AssadHashmi,
joshua-warburton and
cmannett85-arm
AssadHashmi
approved these changes
Jan 13, 2023
dolanzhao
pushed a commit
that referenced
this pull request
Jan 30, 2023
This pulls out code for encoding and decoding 8-bit floating-point immediate values into helper functions that can be re-used for future instructions with similar operands. This commit also renames the fpimm13 operand to fpimm8_13 Many immediate value operands follow the naming convention: <type>imm<size>[_<lsb>] So you would expect fpimm13 to be a 13-bit floating-point immediate value. It is actually an 8-bit floating-point immediate value at bit 13 so following the above naming convention it should be called fpimm8_13. Issues: #4393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls out code for encoding and decoding 8-bit floating-point immedate values into helper functions that can be re-used for future instructions with similar operands.
Issues: #4393, #2626