Skip to content

Conversation

Felix-Dynamsoft
Copy link
Contributor

@Felix-Dynamsoft Felix-Dynamsoft commented Jun 14, 2024

Problem

Class names and variables are not standardized between docs and the sample codes.

Solution

  • Standardize the class name for #camera-view-container and #results
  • Change div-results-container to results-container
  • Change try/catch error to be more descriptive
  • Format code with Prettier - Code Formatter (See style guide)

@Felix-Dynamsoft Felix-Dynamsoft requested a review from Keillion June 14, 2024 21:58
@Felix-Dynamsoft Felix-Dynamsoft changed the title refactor: format and rename classes for js sample refactor: format and standardize js sample Jun 14, 2024
@Felix-Dynamsoft Felix-Dynamsoft changed the title refactor: format and standardize js sample refactor: format and standardize hello-word js Jun 14, 2024
@Keillion Keillion merged commit 5bb9c3e into main Jun 20, 2024
@Felix-Dynamsoft Felix-Dynamsoft deleted the enhancement/felix/5 branch August 28, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants