fix: match hello-world js to sample on docs #178
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing and merging the changes to #174 |
felixindrawan
added a commit
that referenced
this pull request
Jun 18, 2024
Keillion
pushed a commit
that referenced
this pull request
Jun 20, 2024
* refactor: format and rename classes for js sample * update resultContainer and input class name * fix: change resultContainer to resultsContainer * refactor: renamed results class * fix: merged #178 changes * fix formatter printWidth to 120 --------- Co-authored-by: felixindrawan <indrawan.felix123@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The sample on the docs https://www.dynamsoft.com/barcode-reader/docs/web/programming/javascript/user-guide/#hello-world---simplest-implementation and the sample code on the demo doesn't match.
Solution
Match how we process the result on the demo.
Additionally, we also should format the code with
Prettier-moreextension`