Fix compiler dependent bug for betr #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the most recent intel compiler, the betr code crashes when running on more than 24 cpus on edison. The cause of this crash was traced and found related to the passing of arrays between different subroutines. Now all arrays are passed with explicit specification of their lower and upper bounds, so betr can run without noticable issue. However, the advection capability of betr has to be turned off, because the new intel compiler does not work well with passing generic data types. A workaround is developed in betr-v2, and will be integrated in the future. This fix does not affect codes other than betr, so is bfb.
|
Probably a good bug to fix but we're also trying to move away from Intel 15 to Intel 17. |
amametjanov
reviewed
Mar 31, 2017
| @@ -118,8 +118,9 @@ subroutine betr_tracer_massbalance_check(bounds, lbj, ubj, numf, filter, betrtra | |||
| call tracerflux_vars%flux_summary(c, betrtracer_vars) | |||
|
|
|||
| do kk = 1, ngwmobile_tracers | |||
| errtracer(c,kk) = beg_tracer_molarmass(c,kk)-end_tracer_molarmass(c,kk) & | |||
| + tracer_flx_netpro(c,kk)-tracer_flx_netphyloss(c,kk) | |||
| if(c>maxval(filter))print*,'crazy happend' | |||
There was a problem hiding this comment.
Could you add a more informative message here? Maybe print vals of c and maxval(filter).
There was a problem hiding this comment.
This looks like a left over. I might just delete it.
| @@ -1412,7 +1413,6 @@ subroutine diagnose_advect_water_flux(bounds, num_hydrologyc, filter_hydrologyc, | |||
|
|
|||
| enddo | |||
|
|
|||
| deallocate(h2osoi_liq_copy) | |||
There was a problem hiding this comment.
This deallocate was removed, but not added elsewhere.
There was a problem hiding this comment.
This no longer needed.
| @@ -1461,7 +1461,6 @@ subroutine diagnose_drainage_water_flux(bounds, num_hydrologyc, filter_hydrology | |||
| enddo | |||
| enddo | |||
|
|
|||
| deallocate(h2osoi_liq_copy) | |||
There was a problem hiding this comment.
This deallocate was removed, but not added elsewhere. May cause a memory leak?
There was a problem hiding this comment.
The deallocation occurs after the code execution is done. So it follows the implicit deallocation rule as in other extended data types.
|
@rljacob, Yes, I'm aware that we are moving to 17. But that decision to move was made after I explored this bug. |
No test needed! BFB
bishtgautam
approved these changes
Mar 31, 2017
amametjanov
approved these changes
Mar 31, 2017
bishtgautam
pushed a commit
that referenced
this pull request
Apr 6, 2017
BeTR failed when running with the 15.x intel compiler. By updating the compiler configuration and enforce some array shapes during argument passing fixed the bug. Fixes #1326 [BFB]
bishtgautam
pushed a commit
that referenced
this pull request
Apr 10, 2017
BeTR failed when running with the 15.x intel compiler. By updating the compiler configuration and enforce some array shapes during argument passing fixed the bug. Fixes #1326 [BFB]
agsalin
pushed a commit
that referenced
this pull request
May 1, 2017
Force user to always go through case.submit
jgfouca
pushed a commit
that referenced
this pull request
Jun 2, 2017
BeTR failed when running with the 15.x intel compiler. By updating the compiler configuration and enforce some array shapes during argument passing fixed the bug. Fixes #1326 [BFB]
jgfouca
pushed a commit
that referenced
this pull request
Feb 27, 2018
BeTR failed when running with the 15.x intel compiler. By updating the compiler configuration and enforce some array shapes during argument passing fixed the bug. Fixes #1326 [BFB]
jgfouca
pushed a commit
that referenced
this pull request
Mar 14, 2018
BeTR failed when running with the 15.x intel compiler. By updating the compiler configuration and enforce some array shapes during argument passing fixed the bug. Fixes #1326 [BFB]
rljacob
pushed a commit
that referenced
this pull request
Apr 16, 2021
BeTR failed when running with the 15.x intel compiler. By updating the compiler configuration and enforce some array shapes during argument passing fixed the bug. Fixes #1326 [BFB]
rljacob
pushed a commit
that referenced
this pull request
May 6, 2021
BeTR failed when running with the 15.x intel compiler. By updating the compiler configuration and enforce some array shapes during argument passing fixed the bug. Fixes #1326 [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BeTR failed when running with the 15.x intel compiler. By updating
the compiler configuration and enforce some array shapes during
argument passing fixed the bug.
Fixes #1326
[BFB]