Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler dependent bug for betr #1362

Merged
merged 3 commits into from
Apr 10, 2017
Merged

Fix compiler dependent bug for betr #1362

merged 3 commits into from
Apr 10, 2017

Commits on Mar 22, 2017

  1. bug fix for array-passing related crash of betr 

    With the most recent intel compiler, the betr code crashes when running on more than 24 cpus on edison.
The cause of this crash was traced and found related to the passing of arrays between different subroutines.
Now all arrays are passed with explicit specification of their lower and upper bounds, so betr can run without
noticable issue. However, the advection capability of betr has to be turned off, because the new intel compiler
does not work well with passing generic data types. A workaround is developed in betr-v2, and will be integrated
in the future.

This fix does not affect codes other than betr, so is bfb.
    @jinyuntang
    jinyuntang committed Mar 22, 2017
    Configuration menu
    Copy the full SHA
    c37ddeb View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2017

  1. Adds a test for BeTR

    Gautam Bisht committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    27fbef2 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2017

  1. removed a redundant line 

    No test needed!

BFB
    @jinyuntang
    jinyuntang committed Mar 31, 2017
    Configuration menu
    Copy the full SHA
    b16d114 View commit details
    Browse the repository at this point in the history