Update mpas-source submodule for ocean halo reuse #2387
Conversation
mark-petersen
force-pushed
the
mark-petersen/ocean/halo_reuse
branch
2 times, most recently
from
aea1ec1
to
0537467
Compare
|
OK, I updated so only mpas-source is altered. Tested with: |
|
@philipwjones and @Larofeticus FYI here is the E3SM PR. Could you please link to or describe the past testing that you've done. @jonbob will do a few standard tests on this PR as well, when he is back next week. |
mark-petersen
force-pushed
the
mark-petersen/ocean/halo_reuse
branch
from
0537467
to
64ac97e
Compare
|
The recorded history of this is. Adding three routines to closed repository MPAS develop which facilitate reusing halo exchange data structures throughout a simulation. Using those routines in the ocean core revealed a memory leak. Memory leak found and corrected in framework. Ocean core modification to reuse halo data structures in the open repository: |
|
I ran two identical T62_oECv3.GMPAS-IAF.cori-knl_intel tests, one with and one without this mpas update. After one month, the results were bfb and the ocean performance increased slightly from 2.16 to 2.22 sypd. I saw no sign of a memory leak either, so I think this PR can be satisfied. |
This PR updates the mpas-source submodule for ocean halo reuse Tested with: * ERS_Ld3.T62_oQU240.GMPAS-IAF.cori-knl_intel * SMS_D.T62_oQU120_ais20.MPAS_LISIO_TEST.cori-knl_gnu * T62_oECv3.GMPAS-IAF.cori-knl_intel one-month runs, BFB w/ and w/o this update [BFB]
|
merged to next |
This PR updates the mpas-source submodule for ocean halo reuse Tested with: * ERS_Ld3.T62_oQU240.GMPAS-IAF.cori-knl_intel * SMS_D.T62_oQU120_ais20.MPAS_LISIO_TEST.cori-knl_gnu * T62_oECv3.GMPAS-IAF.cori-knl_intel one-month runs, BFB w/ and w/o this update [BFB]
|
merged to master |
Deccsmize Remove text 'ccsm' and 'cesm' and replace appropriately Test suite: scripts_regression_tests.py Test baseline: Test namelist changes: Test status: bit for bit Fixes #2387 User interface changes?: Update gh-pages html (Y/N)?: Code review:
Update mpas-source submodule for ocean halo reuse