This repository has been archived by the owner on Oct 23, 2020. It is now read-only.
Remove vestigal calls to config pool routines from halo exchanges. #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-petersen
approved these changes
Mar 14, 2018
mgduda
approved these changes
Mar 14, 2018
|
@Larofeticus Thanks very much for the new PR. |
Consequentially removes memory leak in halo reuse.
mark-petersen
force-pushed
the
fix_config_pool_leak
branch
from
6f00f13
to
833a164
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to comment in #1501 config_pool entries created in halo exchanges are no longer used and can be removed. Config_pool entries when ported to halo data structure reuse also cause a memory leak.
According to comment in #1502 the code builds and passes testing.