Corrects thin ice/snow treatment of enthalpy and other tracers #5630
+47
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be tested as a possible fix to #5124 - mpas-si crashes on small timesteps bug fix For snow/ice thicknesses < puny but > 0, enthalpy and other adjusted tracers are spread evenly among layers. Non-BFB
Corrects possible floating snow during ice loss in thickness_changes non-BFB, bugfix
|
Code was tested in a 15-year fully coupled simulation. MPAS-Analysis of the sea ice can be found here: https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.jeffery/E3SMv2/thin-ice-enthalpy-constant-feature-snow/ Baseline is thin-ice-enthalpy-constant-master |
|
Plots of salt, mass and energy conservation : |
njeffery
added
mpas-seaice
bug fix PR
non-BFB
|
testing now -- thanks @njeffery |
|
@njeffery - this branch does pass my simplified test for the originally reported bug |
|
Great! thanks @jonbob. |
eclare108213
approved these changes
Apr 25, 2023
|
@proteanplanet - when you get a chance, could you please review this? Thanks |
proteanplanet
approved these changes
May 3, 2023
There was a problem hiding this comment.
This was successfully tested on a 3-month D-case. While a short simulation, the difference from the current master is provided here:
North South
IceExtent: +5.17637e+05 +4.16285e+05
IceVolume: -8.02587e+02 +1.09206e+03
SnowVolume: +1.58975e+02 +1.65821e+02
KineticEnergy: +5.82797e+13 +4.18521e+13
Without some git manipulation, I was unable to run the e3sm_ice_developer test suite on the code. However, it passed the three-month smoke test.
jonbob
added a commit
that referenced
this pull request
May 15, 2023
#5630) Corrects thin ice/snow treatment of enthalpy and other tracers This fix redistributes enthalpy and other tracers evenly in snow and ice when their respective thicknesses are < 1e-15 . Previously, these tracers were zero'd non-conservatively. Also corrects a bug in the zeroing of snow thicknesses, and removes snow in thickness_changes if the ice vanishes. Fixes #5124 [non-BFB]
|
Successfully completes, but shows expected DIFFs for:
merged to next |
|
Thanks @jonbob ! |
|
merged to master and expected DIFFs blessed -- except for chrysalis next which did not report |
mkstratos
added a commit
to mkstratos/E3SM
that referenced
this pull request
Aug 11, 2023
With the fix in MPAS-SI: Corrects thin ice/snow treatment of enthalpy and other tracers (E3SM-Project#5630) the TSC test can now generate a baseline with dtime=1 using MPAS-SI
apcraig
added a commit
to apcraig/Icepack
that referenced
this pull request
Aug 28, 2023
Adopted from E3SM-Project/E3SM#5630 "This fix redistributes enthalpy and other tracers evenly in snow and ice when their respective thicknesses are < 1e-15 . Previously, these tracers were zero'd non-conservatively. Also corrects a bug in the zeroing of snow thicknesses, and removes snow in thickness_changes if the ice vanishes."
16 tasks
apcraig
added a commit
to CICE-Consortium/Icepack
that referenced
this pull request
Aug 30, 2023
* Corrects thin ice/snow treatment of enthalpy and other tracers Adopted from E3SM-Project/E3SM#5630 "This fix redistributes enthalpy and other tracers evenly in snow and ice when their respective thicknesses are < 1e-15 . Previously, these tracers were zero'd non-conservatively. Also corrects a bug in the zeroing of snow thicknesses, and removes snow in thickness_changes if the ice vanishes." * Clean up modifications
rljacob
added a commit
that referenced
this pull request
Sep 11, 2023
Revert TSC non-b4b test to use the F2010 compset With the fix in MPAS-SI: "Corrects thin ice/snow treatment of enthalpy and other tracers" (#5630) the TSC test can now generate a baseline with dtime=1 using MPAS-SI [non-BFB] only for TSC test
rljacob
added a commit
that referenced
this pull request
Sep 14, 2023
Revert TSC non-b4b test to use the F2010 compset With the fix in MPAS-SI: "Corrects thin ice/snow treatment of enthalpy and other tracers" (#5630) the TSC test can now generate a baseline with dtime=1 using MPAS-SI [non-BFB] only for TSC test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix redistributes enthalpy and other tracers evenly in snow and ice when their respective thicknesses are < 1e-15 . Previously, these tracers were zero'd non-conservatively.
Also corrects a bug in the zeroing of snow thicknesses, and removes snow in thickness_changes if the ice vanishes.
Fixes #5124
[non-BFB]