Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FRIS meshes #6270

Merged
merged 15 commits into from
Mar 26, 2024
Merged

Add FRIS meshes #6270

merged 15 commits into from
Mar 26, 2024

Conversation

irenavankova
Copy link
Contributor

@irenavankova irenavankova commented Feb 28, 2024 •
edited by xylar
Loading

Meshes with high resolution in the southern Weddell Sea and beneath the Filchner Ronne Ice Shelf (FRIS). The meshes go down to 1, 2, 4, and 8 km beneath FRIS and on the continental shelf in front of it.

Meshes are:
FRISwISC01to60E3r1
FRISwISC02to60E3r1
FRISwISC04to60E3r1
FRISwISC08to60E3r1

They are intended only for use in E3SM G-case simulations. Mapping and domain files for supporting B-cases or other coupled configurations are not included and will not be supported.

Related Ocean Discussion is here:

E3SM-Ocean-Discussion#75

@irenavankova
Resolved by including both ICOS and FRIS04
4a889a7
@irenavankova
FRISwISC04to60 put in mono for aave files
d5a9bb6
@irenavankova
FRISwISC04to60 added and generated sss restoring file
4b74712
@irenavankova
changed 20230913 for 20230817
f992496
@irenavankova
ic typo
828889d
@irenavankova
FRISwISC04to60 added and generated DIB file
d136d8a
@irenavankova
Resolved by including both ICOS and FRIS01-08
f3bff9e
@irenavankova
changed dates on domain failes from Jon on 2 and 8 km grids
8f6bb05
@irenavankova
Resolved by keeping integer multiple timestep for F08
f74a9e6
@irenavankova
Resolved by keeping new timesteps for F08-01
4bebdf5
@irenavankova
added gmHorizontalTaper to montly input and io_type="pnetcdf,cdf5" to…
8eb428b 
… FRIS grids
@irenavankova
changed dates for es3m files from Jon for 1 km
96ede2a
@irenavankova
Change Gcase coupling time step for all FRIS grids
50af3a9
@irenavankova
corrected nx for each mesh in cime_config/config_grids.xml
c2c4b8b
@irenavankova
new domain files for v3 - updated for all FRIS meshes
7bed367
@xylar xylar added mpas-ocean mpas-seaice BFB PR leaves answers BFB Stealth PR has feature which, if turned on, could change climate. fka FCC labels Feb 29, 2024
@xylar xylar self-requested a review February 29, 2024 10:23
@xylar
Copy link
Contributor

xylar commented Feb 29, 2024

@irenavankova, do you have any links to analysis you have run for simulations with these meshes? I know they aren't with this exact version of the branch but that would demonstrate that the meshes work as expected.

xylar
xylar approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran 5-day smoke tests on the coarsest 2 meshes and shorter tests on the 2 finer meshes on Chrysalis.

I am also approving based on test results for each mesh that I have seen from @irenavankova over the past year.

@irenavankova
Copy link
Contributor Author

@irenavankova, do you have any links to analysis you have run for simulations with these meshes? I know they aren't with this exact version of the branch but that would demonstrate that the meshes work as expected.

No, as it is all run on chicoma there isn't web access, but I could put some on Anvil if you like?

@xylar
Copy link
Contributor

xylar commented Feb 29, 2024

That's up to you but I think it wouldn't hurt to have a few example results from these meshes if it's not too much trouble.

@irenavankova
Copy link
Contributor Author

Here is an example of MPAS Analysis from the 4 km mesh, years 9-10, Gcase:

https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.vankova/analysis/F4_spinup/clim_9-10_ts_1-10/html/ocean/index.html

@xylar
Copy link
Contributor

xylar commented Mar 1, 2024

Very exciting, thanks @irenavankova! The enhanced eddy activity from the higher resolution can be seen in:
image
and the ability to better resolve topography is also visible in transects like:
image

@rljacob
Copy link
Member

rljacob commented Mar 21, 2024

notes: needs netcdf3 conversion for some mapping files.

@xylar
Copy link
Contributor

xylar commented Mar 22, 2024

@jonbob and @rljacob, which mapping files need conversion?

@jonbob
Copy link
Contributor

jonbob commented Mar 22, 2024

@xylar -- a lot of the ones I had made with my script. It turns out the tempest default output is not what e3sm wants to use. I was going to fix them today and be ready to merge this PR.

@xylar
Copy link
Contributor

xylar commented Mar 22, 2024

Okay, great! I'm sorry for the extra work for you, though.

@jonbob
Copy link
Contributor

jonbob commented Mar 22, 2024

The mapping files are now converted and Ill work on merging this as soon as I can

jonbob added a commit that referenced this pull request Mar 25, 2024
@jonbob
Merge branch 'irenavankova/ocn/add-FRIS-meshes' into next (PR #6270)
3f6b654 
Add FRIS meshes

Adds meshes with high resolution in the southern Weddell Sea and beneath
the Filchner Ronne Ice Shelf (FRIS). The meshes go down to 1, 2, 4, and
8 km beneath FRIS and on the continental shelf in front of it.

Meshes are:
* FRISwISC01to60E3r1
* FRISwISC02to60E3r1
* FRISwISC04to60E3r1
* FRISwISC08to60E3r1

They are intended only for use in E3SM G-case simulations. Mapping and
domain files for supporting B-cases or other coupled configurations are
not included and will not be supported.

[BFB] for all currently tested configurations
@jonbob jonbob removed the Stealth PR has feature which, if turned on, could change climate. fka FCC label Mar 25, 2024
@jonbob
Copy link
Contributor

jonbob commented Mar 25, 2024

confirmed all new files are in the correct format and on the inputdata server. Passes:

  • ERS_Ld5.T62_oQU120.CMPASO-NYF.chrysalis_intel
  • ERP_Ld3.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.chrysalis_intel.allactive-pioroot1

merged to next

@jonbob jonbob merged commit b170268 into E3SM-Project:master Mar 26, 2024
10 checks passed
@jonbob
Copy link
Contributor

jonbob commented Mar 26, 2024

merged to master

xylar added a commit to xylar/compass that referenced this pull request May 8, 2024
@xylar
Update E3SM-Project submodule
3e22a23 
This merge updates the E3SM-Project submodule from [93e511d](https://github.com/E3SM-Project/E3SM/tree/93e511d) to [31e0924](https://github.com/E3SM-Project/E3SM/tree/31e0924).

This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list):
- [ ]  (ocn) E3SM-Project/E3SM#6256
- [ ]  (ocn) E3SM-Project/E3SM#6224
- [ ]  (ocn) E3SM-Project/E3SM#6270
- [ ]  (ocn) E3SM-Project/E3SM#6293
- [ ]  (ocn) E3SM-Project/E3SM#6321
- [ ]  (ocn) E3SM-Project/E3SM#6262
- [ ]  (ocn) E3SM-Project/E3SM#6300
- [ ]  (ocn) E3SM-Project/E3SM#6334
- [ ]  (ocn) E3SM-Project/E3SM#6371
- [ ]  (ocn) E3SM-Project/E3SM#6288
@xylar xylar mentioned this pull request May 8, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xylar xylar xylar approved these changes

Assignees

@jonbob jonbob

Labels
BFB PR leaves answers BFB mpas-ocean mpas-seaice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@irenavankova @xylar @rljacob @jonbob