Add frazil to ice-shelf melt rates #6300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xylar
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
I ran a 5-year CRYO1850.ne30pg2_r05_IcoswISC30E3r5 simulation with this branch. The analysis output from just the ice-shelf melting, frazil accretion, and total of the two can be seen here:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis/20240226.CRYO1850.ne30pg2_r05_IcoswISC30E3r5.include_frazil.chrysalis/yrs_5-5/ocean/index.html
This is an important fix for us to include in our model output and analysis!
|
@cbegeman, could you give this another look? Hopefully, it will be quick since you already approved this on Ocean-Discussion. |
cbegeman
approved these changes
Apr 12, 2024
jonbob
added a commit
that referenced
this pull request
Apr 23, 2024
…6300) Add frazil to ice-shelf melt rates New variable frazilIceFreshwaterFlux is introduced to keep track of frazil ice formation instanatenously (and not only commulatively over coupling timestep as before) New variable landIceFreshwaterFluxTotal is introduced to keep track of total melt rates that includes both interface melt/freeze and frazil ice formation, so that landIceFreshwaterFluxTotal = landIceFreshwaterFlux + frazilIceFreshwaterFlux The changes here affect diagnostics only. [BFB]
|
passes:
merged to next |
|
merged to master |
|
Woohoo! Thanks @jonbob! |
|
And thanks very much, @irenavankova! |
xylar
added a commit
to xylar/compass
that referenced
this pull request
May 8, 2024
This merge updates the E3SM-Project submodule from [93e511d](https://github.com/E3SM-Project/E3SM/tree/93e511d) to [31e0924](https://github.com/E3SM-Project/E3SM/tree/31e0924). This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list): - [ ] (ocn) E3SM-Project/E3SM#6256 - [ ] (ocn) E3SM-Project/E3SM#6224 - [ ] (ocn) E3SM-Project/E3SM#6270 - [ ] (ocn) E3SM-Project/E3SM#6293 - [ ] (ocn) E3SM-Project/E3SM#6321 - [ ] (ocn) E3SM-Project/E3SM#6262 - [ ] (ocn) E3SM-Project/E3SM#6300 - [ ] (ocn) E3SM-Project/E3SM#6334 - [ ] (ocn) E3SM-Project/E3SM#6371 - [ ] (ocn) E3SM-Project/E3SM#6288
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New variable frazilIceFreshwaterFlux is introduced to keep track of frazil ice formation instanatenously (and not only commulatively over coupling timestep as before)
New variable landIceFreshwaterFluxTotal is introduced to keep track of total melt rates that includes both interface melt/freeze and frazil ice formation, so that landIceFreshwaterFluxTotal = landIceFreshwaterFlux + frazilIceFreshwaterFlux.
Associted changes in MPAS-Analysis reflect this to plot Antarctic meltrate maps with landIceFreshwaterFluxTotal instead of landIceFreshwaterFlux:
MPAS-Dev/MPAS-Analysis#989
The changes here affect diagnostics only.
Related Ocean Discussion is here:
E3SM-Ocean-Discussion#79