-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If available, plot climatology of total melt rate #989
If available, plot climatology of total melt rate #989
Conversation
I still need to make these changes to the |
077052b
to
519349f
Compare
TestingI ran analysis on an old simulation to ensure backwards compatibility: Then, I ran analysis on a new simulation with the branch from E3SM-Ocean-Discussion/E3SM#79: Both worked as expected. No errors were raised with the old simulation and the plots for the missing variables simply do nothing. For the analysis on the new simulation, comparison with observations only occurs for the total flux, not the interface melt rate (or the frazil flux). I verified that the expected variable is used in the melt time series for each analysis run -- the old |
@irenavankova, do you want to have a look at this as well? |
The test suite ran successfully, see https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xasay-davis/analysis_testing/chrysalis/switch-to-land-ice-freshwater-flux-total/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just made a couple minor suggestions. Otherwise, I think this looks good!
For the Antarctic Melt Time Series, if the new variables aren't available, do you still want the header of the section to read |
Yes, I realized there's that conflict in meaning. We've been using "total flux" for a while to mean the integrated flux. But we could change it to integrated instead for clarity. |
Also plot constituents: the melt rate at the interface and the frazil flux below ice shelves.
We still use the old variable if necessary for backwards compatibility.
6bf8b0d
to
20dd7ca
Compare
@irenavankova and @cbegeman, I believe I've addressed your suggested changes. Could you take a look at |
This looks good to me. |
I agree. Thanks for making those changes! |
Thanks so much @cbegeman and @irenavankova! |
Missed in MPAS-Dev#989
I have one comment here - the title on frazil plots is a bit too long. The result is that the width of the figure changes based on the season. What that means is that it is not as easy to visually compare seasonal changes by flicker the figures. Just a detail though. |
Okay, I can make another PR to fix that. |
Also plot constituents: the melt rate at the interface and the frazil flux below ice shelves.
This is to support changes in E3SM-Ocean-Discussion/E3SM#79