Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix total land-ice freshwater flux in data mode #114

Closed

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Oct 30, 2024

Previously, the total was only being computed when thermodynamics below ice shelves are actively computed, whereas we need to compute the total of the interface flux and the frazil flux when the interface flux comes from a data file as well. While we expect the frazil flux to be zero, these code modifications do not assume or require this to be true.

This PR addresses E3SM-Project#6719

@xylar xylar requested a review from darincomeau October 30, 2024 01:30
@xylar xylar self-assigned this Oct 30, 2024
@xylar xylar force-pushed the ocn/fix-dismf-total-lifwf branch from 7ce3d1f to 13b1062 Compare October 30, 2024 02:25
@xylar
Copy link
Collaborator Author

xylar commented Oct 31, 2024

Here is MPAS-Analysis from a 2-year G-case with DISMF:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis/20241029.GMPAS-JRA1p5-DIB-DISMF.TL319_IcoswISC30E3r5.fix_total_ismf.chrysalis/ocean/index.html

The total flux is no longer zero, as desired.

image

The variability in time is due to frazil, and shows that it can be pretty significant:

image

@xylar
Copy link
Collaborator Author

xylar commented Oct 31, 2024

@darincomeau, anything you'd like to do to sanity-check this before it goes to E3SM? Since it's BFB, I think my 2-year test should be sufficient. But I could run a couple of B-case tests first to make sure it's really BFB as it should be. If you're okay with it, I'd do that once we move to E3SM, though.

@xylar
Copy link
Collaborator Author

xylar commented Oct 31, 2024

Also, do we need to add this to the BlueTip table?

@darincomeau
Copy link
Collaborator

Thanks @xylar for the fix here!

Do we know what happened where this functionality stopped working? In runs I had done earlier this year, DISMF was showing up as expected:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.dcomeau/E3SMv3/20240227.v3.LR.CRYO1850-DISMF.paolo.chrysalis/yrs151-200/ocean/index.html#antmelttime
image

@xylar
Copy link
Collaborator Author

xylar commented Nov 1, 2024

@darincomeau, yes, @irenavankova figured out in her work that we were missing frazil in the total land-ice melt flux. She fixed that in E3SM in:
E3SM-Project#6300
and I fixed it in MPAS-Analysis in:
MPAS-Dev/MPAS-Analysis#989

I think we assumed that frazil would simply be disabled in cases with DISMF and didn't include it in the total but I think this approach is better. If frazil is disabled, the total is simply the same as the interface value and no special conditions are needed for plotting in MPAS-Anslysis.

@darincomeau
Copy link
Collaborator

@xylar thanks for the fix! agree we can move this over to main repo. BFB tests against baselines with cryo_developer_suite should cover it?

@darincomeau
Copy link
Collaborator

and yes we'll add this PR alongside the scaledDISMF PR in the SORRMv3 development table

Previously, the total was only being computed when thermodynamics
below ice shelves are actively computed, whereas we need to
compute the total of the interface flux and the frazil flux
when the interface flux comes from a data file as well.  While we
expect the frazil flux to be zero, these code modifications do not
assume or require this to be true.
@xylar
Copy link
Collaborator Author

xylar commented Nov 1, 2024

Closed in favor of E3SM-Project#6729

@xylar xylar closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants