Add DROF to moab driver #6410
Merged
Add DROF to moab driver #6410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@jonbob should we switch to the new domain file as the default? Do you know the history of why it doesn't have a pole at 90N? |
rljacob
reviewed
May 13, 2024
| @@ -846,7 +846,7 @@ subroutine init_moab_land(bounds, LNDID) | |||
| use spmdmod , only: masterproc | |||
| use iMOAB , only: iMOAB_CreateVertices, iMOAB_WriteMesh, iMOAB_RegisterApplication, & | |||
| iMOAB_DefineTagStorage, iMOAB_SetIntTagStorage, iMOAB_SetDoubleTagStorage, & | |||
| iMOAB_ResolveSharedEntities, iMOAB_CreateElements, iMOAB_MergeVertices, iMOAB_UpdateMeshInfo | |||
There was a problem hiding this comment.
Also mention these changes in the PR description.
|
@rljacob -- let me look |
|
Jon has mapping weights files ready. |
iulian787
force-pushed
the
iulian787/moab_data_rof
branch
from
41740c2
to
bfc3e0a
Compare
use a data stream file, instead of rof_mesh file
it depends on a moab branch: iulian07/domain_extension
not clear yet why projection has wrong results for rofi
the moab one has extra -1s after projection which is wrong the issue is how we project the map from file we do or we do not consider fractions, masks?
it actually failed on chrysalis, on 4 nodes not clear why, maybe distribution issues, or parameter existence not checked This code looked at projection of Forr_rofi on ocean
iulian787
force-pushed
the
iulian787/moab_data_rof
branch
from
bfc3e0a
to
102b54d
Compare
|
Will merge after #6459 |
|
Please update the PR description with the text you want in the merge commit. |
rljacob
added a commit
that referenced
this pull request
Jun 18, 2024
Extend moab driver for a case with ROF data Case tested: --compset GMPAS-IAF --res T62_oQU240wLI iMOAB_MergeVertices is not used anymore in moab land driver, small correction incorporated into this PR
rljacob
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend moab driver for a case with ROF data
Case tested: --compset GMPAS-IAF --res T62_oQU240wLI
iMOAB_MergeVertices is not used anymore in moab land driver, small correction incorporated into this PR
Update on Jun 12, 2024: I rebased the branch iulian787/moab_data_rof off Jon Wolfe's branch, that introduces corrected files:
[jonbob/cpl/fix-t62-files] (https://github.com/E3SM-Project/E3SM/tree/jonbob/cpl/fix-t62-files)
#6459
This now works with moab master, tested on gce machine at Argonne