Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mapping and domain files created with an incorrect T62 scrip file #6459

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

jonbob
Copy link
Contributor

@jonbob jonbob commented Jun 4, 2024

Several configurations have mapping and domain files made from a T62 scrip file that did not extend to the North pole, which is incorrect and causes some problems in the moab driver. This PR updates those files using a correct T62 scrip file for currently used resolutions.

[NML]
[non-BFB] for tests using T62

@jonbob jonbob added Coupler non-BFB PR makes roundoff changes to answers. data-models labels Jun 4, 2024
@jonbob jonbob requested a review from rljacob June 4, 2024 20:09
@jonbob jonbob self-assigned this Jun 4, 2024
Copy link

github-actions bot commented Jun 4, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6459/
on branch gh-pages at 2024-06-12 15:59 UTC

@rljacob rljacob requested a review from iulian787 June 4, 2024 20:21
@iulian787
Copy link
Contributor

@jonbob Hi Jon, I tried this case on chrysalis, --compset GMPAS-IAF --res T62_oQU240wLI , this is the case folder:
/lcrc/group/e3sm/iulian/CASES/T62o240_jon
source code is here:
/lcrc/group/e3sm/iulian/E3SM, it is at this commit: 565a93e
check input data is not finding a file:

Model datm missing file domainfile = '/lcrc/group/e3sm/data/inputdata/share/domains/domain.lnd.T62_oQU240wLI_mask.240513.nc'

What machine should I try?

@jonbob
Copy link
Contributor Author

jonbob commented Jun 12, 2024

Sorry @iulian787 -- we had changed a filename convention and I missed it when I updated to the new files. Could you please try a clean checkout and try again?

@iulian787
Copy link
Contributor

Thanks @jonbob , it works now!
I rebased my data rof branch off your branch, and it works now with the new files, without other modifications :)

Copy link
Contributor

@iulian787 iulian787 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested --compset GMPAS-IAF --res T62_oQU240wLI with this branch, and the files can be successfully processed now by MOAB and tempestremap

@rljacob
Copy link
Member

rljacob commented Jun 17, 2024

@jonbob can you merge this? I can do it if you're busy.

@jonbob
Copy link
Contributor Author

jonbob commented Jun 17, 2024

@rljacob -- I'll do that today. I need to make sure all the new files are on the inputdata server

@jonbob jonbob added the NML label Jun 17, 2024
jonbob added a commit that referenced this pull request Jun 17, 2024
Update mapping and domain files created with an incorrect T62 scrip file

Several configurations have mapping and domain files made from a T62
scrip file that did not extend to the North pole, which is incorrect and
causes some problems in the moab driver. This PR updates those files
using a correct T62 scrip file for currently used resolutions.

[non-BFB] for tests using T62
@jonbob
Copy link
Contributor Author

jonbob commented Jun 17, 2024

testing shows NML and regular DIFF as expected for:

  • ERS_Ld5.T62_oQU120.CMPASO-NYF.chrysalis_intel

Also passes, as expected:

  • ERP_Ld3.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.chrysalis_intel.allactive-pioroot1

merged to next

@jonbob jonbob merged commit f0eada3 into master Jun 18, 2024
21 checks passed
@jonbob jonbob deleted the jonbob/cpl/fix-t62-files branch June 18, 2024 15:02
@jonbob
Copy link
Contributor Author

jonbob commented Jun 18, 2024

merged to master and expected NML and regular DIFFs blessed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Coupler data-models NML non-BFB PR makes roundoff changes to answers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants