-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix import of moved method in MVKO test #6671
Fix import of moved method in MVKO test #6671
Conversation
CIME.utils.append_testlog was moved in ESMCI/cime#4660 This updates the MVKO test to use that method (other CIME SystemTests were updated in that PR) [bfb]
The append_testlog error went away but now the MVKO test is reporting a fail:
|
The baseline its comparing against is in /lcrc/group/e3sm2/baselines/chrys/intel/master/MVKO_PS.T62_oQU240.GMPAS-NYF.chrysalis_intel and its dated May 8. But there should be no changes in answers for a WCYCLE config of MPAS since v3.0.0. @jonbob do you know if anything might have changed in GMPAS-NYF since May 8? |
@rljacob -- I'll look and see if we changed anything specifically for NYF or the oQU240 mesh, but nothing is coming to mind |
Sure its non-BFB but would it be climate changing? That seems to be what this test is saying. |
@rljacob - I guess it could be climate-changing? But the oQU240 is a grid we only use for testing and it's not considered scientifically validated. Maybe the only real way to find out is to run this test with and without the PR that changed the mapping and domain files and see. Please just yell if that's something you want me to take on |
The different map files seem to be the cause for the climate changing differences. This test: https://web.lcrc.anl.gov/public/e3sm/ac.mkelleher/evv/MVKO_PS.T62_oQU240.GMPAS-NYF.chrysalis_intel.C.20241008_121250_blo0rd run with current master and the old map files passes. |
Ok I'll bless it. Its better if oQU240 is more sensitive then less sensitive. |
CIME.utils.append_testlog
was moved in ESMCI/cime#4660This updates the MVKO test to use that method (other CIME SystemTests were updated in that PR)
[BFB]