Fix a bug in VBS SOA gas-aerosol partition calculation #6502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingxuanwupnnl
added
Atmosphere
bug fix PR
non-BFB
|
hwangacme
approved these changes
Jul 7, 2024
mingxuanwupnnl
changed the title
mkshriva
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug fix corrects issue #6474
In subroutine mam_soaexch_vbs_1subarea in components/eam/src/chemistry/modal_aero/modal_aero_amicphys.F90
The calculation of p0_soa_298 is not correct. Temperature of 298 K should be used instead of ambient temperature
This fix has very small impact on global mean climate
See e3sm_diags:
Default tag v3.0.0: https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.mwu/E3SMv3/20240520.v3.LR.F2010.chrysalis/e3sm_diags/atm_monthly_180x360_aave/model_vs_obs_0002-0011/viewer/
VBSfix:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.mwu/E3SMv3/20240520.v3.LR.F2010.VBSfix.chrysalis/e3sm_diags/atm_monthly_180x360_aave/model_vs_obs_0002-0011/viewer/
and IICE comparison:
https://portal.nersc.gov/project/m2136/bin/iice/iice.cgi?url1=https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.mwu/E3SMv3/20240520.v3.LR.F2010.chrysalis/e3sm_diags/atm_monthly_180x360_aave/model_vs_obs_0002-0011/viewer&label1=default%20v3&url2=https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.mwu/E3SMv3/20240520.v3.LR.F2010.VBSfix.chrysalis/e3sm_diags/atm_monthly_180x360_aave/model_vs_obs_0002-0011/viewer&label2=VBSfix&category=&plot=&diff=0&dconfig=vsObs&