Updates land build namelist to account for mask #862
Conversation
clm.buildnml scripts now sends -mask <land-mask> to build-namelist script. This generates land namelist with correct finidat value when there are multiple land-ocean masks (e.g. gx1v6 and oEC60to30) for a single land grid (e.g. ne30np4). This change requires that all new land-ocean masks must be added in components/clm/bld/namelist_files/namelist_definition_clm4_5.xml Fixes #861 [NML]
|
@bishtgautam thanks for fixing this. I don't understand the impact of the bug. Can you briefly explain what the consequences of this bug were? Will the fix change answers? @rljacob : this should probably be also incorporated in v1.0.0-alpha.5? |
|
At present, it appers that there is no valid compset + resolution + land ic file combination in which this bug manifests itself. But, let's assume that we have a land ic file for |
clm.buildnml scripts now sends -mask to build-namelist script. This generates land namelist with correct finidat value when there are multiple land-ocean masks (e.g. gx1v6 and oEC60to30) for a single land grid (e.g. ne30np4). This change requires that all new land-ocean masks must be added in components/clm/bld/namelist_files/namelist_definition_clm4_5.xml Fixes #861 [NML]
|
Hi @jonbob, In this PR, the land build namelist is modified w.r.t. land/ocean mask, so I'm bringing the change to your attention. If you add new land/ocean mask, don't forget to add them in the land namelist_definition_clm4_5.xml#L1125. |
|
@bishtgautam - thanks for letting me know. And I'll be careful. Just out of curiosity, does this include the other two resolutions we had discussed -- ne30_oRRS30to5 and ne30_oQU120? |
|
|
|
sorry -- cut-and-paste error. Yes, the ne30_oRRS30to10 |
|
@rljacob : you can decide whether this should go in alpha.5 or be merged later. |
|
It will be on master today. |
|
Hi @rljacob , will this PR on master today as planned? |
clm.buildnml scripts now sends -mask to build-namelist script. This generates land namelist with correct finidat value when there are multiple land-ocean masks (e.g. gx1v6 and oEC60to30) for a single land grid (e.g. ne30np4). This change requires that all new land-ocean masks must be added in components/clm/bld/namelist_files/namelist_definition_clm4_5.xml Fixes #861 [NML]
|
@tangq this is also now on master and in the new alpha.5 tag. |
add ability to remove tabs in shr_string_lalign Removal of tabs from strings in stream files Test suite: scripts_regression_tests also manual verification that if tabs were introduced in a streams text file (e.g. datm.streams.txt.CORE2_NYF.GISS) then the resulting data model behaved correctly Test baseline: Test namelist changes: Test status: bit for bit Fixes #862 User interface changes?: None Code review:sacks, edwards,
Convert all tabs to spaces in data model stream txt files Test suite: scripts_regression_tests also manual verification that if tabs were introduced in a streams text file (e.g. datm.streams.txt.CORE2_NYF.GISS) then the resulting data model behaved correctly Test baseline: Test namelist changes: Test status: bit for bit Fixes #862 User interface changes?: None Code review: billsacks
clm.buildnml scripts now sends -mask to build-namelist script. This generates land namelist with correct finidat value when there are multiple land-ocean masks (e.g. gx1v6 and oEC60to30) for a single land grid (e.g. ne30np4). This change requires that all new land-ocean masks must be added in components/clm/bld/namelist_files/namelist_definition_clm4_5.xml Fixes #861 [NML]
clm.buildnml scripts now sends -mask to
build-namelist script. This generates land namelist
with correct finidat value when there are multiple
land-ocean masks (e.g. gx1v6 and oEC60to30) for a single
land grid (e.g. ne30np4).
This change requires that all new land-ocean masks must
be added in components/clm/bld/namelist_files/namelist_definition_clm4_5.xml
Fixes #861
[NML]