Implement F1850C5AV1C-03 compset #889
Conversation
We need to create a new compset to contain the changes made to tune F1850AV1C for coupled simulations. Initially it is a duplicate of the -02 compset, but it will evolve while tuning and testing, and will presumably end up as F1850C5AV1C-03, so that is the name I have given it here. [bfb] [AG-435]
Added parameter changes (in namelist and hard-coded) and code tweaks to implement the vb47 configuration from Po_lun Ma. [CC] [AG-435]
This commit replaces the hardwired changes to the code using namelist variables. Use case files for some preexisting compsets has to be modified to accomodate these changes. I got rid of some previous hardwired changes to zm_conv.F90 file also. Fixes #754 [BFB] [NML]
|
@susburrows : I have run all the tests which I think were important. Please feel free to merge it to next. |
This PR implements the F1850C5AV1C-03 compset, which has been tuned from the F1850C5AV1C-02 compset to give RESTOM approximately zero. Following are the tuning changes from F1850C5AV1C-02: cldfrc_dp1 changed to 0.045D0 from 0.04D0 clubb_ice_deep changed to 16.e-6 from 20.e-6 clubb_C2rt changed to 1.75D0 from 0.75D0 zmconv_c0_lnd changed to 0.007 from 0.01 seasalt_emis_scale changed to 0.87 from 0.7 cldfrc2m_rhmaxi changed to 1.05D0 from 1.1D0 clubb_c_K10 changed to 0.3 from 0.4 so4_sz_thresh_icenuc changed to 0.1e-6 from 0.01e-6 New namelist entries: ================ clubb_gamma_coef = 0.32 zmconv_ke = 0.5E-6 micro_mg_accre_enhan_fac = 2.0D0 zmconv_tiedke_add = 0.7D0 zmconv_cape_cin = 1 zmconv_mx_bot_lyr_adj = 2 Fixes #754 [BFB] [NML] AG-416 Conflicts: components/cam/bld/build-namelist
|
I quickly reviewed the code changes with Balwinder. Balwinder has done some testing to check that existing compsets are BFB as expected. Merged to next. |
|
@golaz , do we want to change the -L compset to the -03 is in this PR? |
|
Reminder to @singhbalwinder & @susburrows , some of the parameter values will need to change once the final compset has been chosen by the atm group. (This will have no impact on the nightly tests) |
|
How did the nightlies go? |
|
Nightlies came back an hour ago and everything looks good. Namelist diffs are there but that is expected. |
|
Anyone can check the nightly status here: http://my.cdash.org/index.php?project=ACME_Climate |
|
These diffs in the namelist content showed up for every case that uses CAM. |
|
@rljacob , that is not surprising. I have looked through the code, and as far as I can tell, the values of those variables for all prior compsets should reproduce previous results. BTW, how did you get this from CDash? |
|
You have to click on the individual testname and its buried in the TestStatus.log output. https://acme-climate.atlassian.net/wiki/display/Docs/Using+the+ACME+CDash+Dashboard |
|
@susburrows : This branch is ready to be merged to master. Please merge it when you get a chance. |
This PR implements the F1850C5AV1C-03 compset, which has been tuned
from the F1850C5AV1C-02 compset to give RESTOM approximately zero.
Following are the tuning changes from F1850C5AV1C-02:
cldfrc_dp1 changed from 0.04D0 to 0.045D0
clubb_ice_deep changed from 20.e-6 to 16.e-6
clubb_C2rt changed from 0.75D0 to 1.75D0
zmconv_c0_lnd changed from 0.01 to 0.007
seasalt_emis_scale changed from 0.7 to 0.87
cldfrc2m_rhmaxi changed from 1.1D0 to 1.05D0
clubb_c_K10 changed from 0.4 to 0.3
so4_sz_thresh_icenuc changed from 0.01e-6 to 0.1e-6
soag_ext_file changed from 50% of original emissions to 25% of original emissions.
The new file is: aces4bgc_nvsoa_soag_elev_1850_c160507.nc
New namelist entries:
================
clubb_gamma_coef = 0.32 (hardwired to 0.25 for F1850AV1C-02)
zmconv_ke = 0.5E-6 (hardwired to 1E-6 for F1850AV1C-02)
micro_mg_accre_enhan_fac = 2.0D0 (hardwired to 1.0 for F1850AV1C-02)
zmconv_tiedke_add = 0.7D0 (hardwired to 0.5 for F1850AV1C-02)
zmconv_cape_cin = 1 (hardwired to 5 for F1850AV1C-02)
zmconv_mx_bot_lyr_adj = 2 (hardwired to 1 for F1850AV1C-02)
Defaults for zmconv_dmpdz and zmconv_mx_bot_lyr_adj were hard-wired to
be different for L30 and L72. These values are now implemented in the
use_case namelist default files, so their value is easy to find.
Also fixes #754
[BFB]
[NML]
AG-435
Conflicts:
components/cam/bld/build-namelist
|
AFAIK, the final configuration hasn't been chosen yet by the atm group leaders. Hence, tweaks to a couple of the parameters will presumably be required. This PR currently implements the E2 configuration, which is not one of the leading candidates. However, we will only need to change a couple of the namelist parameters associated with this new compset, so it shouldn't need to go through the nightly tests again. At this point, is it better to retract the push to master? or put in a new PR once a decision is made? |
|
@cameronsmith1 : I think we should leave this as-is and do a new PR when there is a decision on the final parameter values. In general reverting commits to master is very undesirable if it can be avoided, and there is no harm in having another PR that updates the parameter values. |
The PR (#889) for F1850C5AV1C-03 was pushed to master before the configuration had been finalized. This commit implements the changes for the chosen configuration (vc10): clubb_gamma_coef = 0.29 seasalt_emis_scale = 1.05 [FCC, NML] [AG-435]
|
This compset was pushed to master before the configuration had been finalized. The compset is finalized in PR #893 . |
Completion of F1850C5AV1C-03 Compset The PR (#889) for F1850C5AV1C-03 was pushed to master before the configuration had been finalized. This commit implements the changes for the chosen configuration (vc10): clubb_gamma_coef = 0.29 seasalt_emis_scale = 1.05 [NML] [AG-435] [BFB] * cameronsmith1/atm/F1850C5AV1C-03b: Completion of F1850C5AV1C-03 Bugfix for default call to compute_tms even if do_tms is not true
Completion of F1850C5AV1C-03 Compset The PR (#889) for F1850C5AV1C-03 was pushed to master before the configuration had been finalized. This commit implements the changes for the chosen configuration (vc10): clubb_gamma_coef = 0.29 seasalt_emis_scale = 1.05 [NML] [AG-435] [BFB] * cameronsmith1/atm/F1850C5AV1C-03b: Completion of F1850C5AV1C-03
This PR implements the F1850C5AV1C-03 compset, which has been tuned
from the F1850C5AV1C-02 compset to give RESTOM approximately zero.
Following are the tuning changes from F1850C5AV1C-02:
cldfrc_dp1 changed from 0.04D0 to 0.045D0
clubb_ice_deep changed from 20.e-6 to 16.e-6
clubb_C2rt changed from 0.75D0 to 1.75D0
zmconv_c0_lnd changed from 0.01 to 0.007
seasalt_emis_scale changed from 0.7 to 0.87
cldfrc2m_rhmaxi changed from 1.1D0 to 1.05D0
clubb_c_K10 changed from 0.4 to 0.3
so4_sz_thresh_icenuc changed from 0.01e-6 to 0.1e-6
soag_ext_file changed from 50% of original emissions to 25% of original emissions.
The new file is: aces4bgc_nvsoa_soag_elev_1850_c160507.nc
New namelist entries:
================
clubb_gamma_coef = 0.32 (hardwired to 0.25 for F1850AV1C-02)
zmconv_ke = 0.5E-6 (hardwired to 1E-6 for F1850AV1C-02)
micro_mg_accre_enhan_fac = 2.0D0 (hardwired to 1.0 for F1850AV1C-02)
zmconv_tiedke_add = 0.7D0 (hardwired to 0.5 for F1850AV1C-02)
zmconv_cape_cin = 1 (hardwired to 5 for F1850AV1C-02)
zmconv_mx_bot_lyr_adj = 2 (hardwired to 1 for F1850AV1C-02)
Defaults for zmconv_dmpdz and zmconv_mx_bot_lyr_adj were hard-wired to
be different for L30 and L72. These values are now implemented in the
use_case namelist default files, so their value is easy to find.
Also fixes #754
[BFB]
[NML]
AG-435
Conflicts:
components/cam/bld/build-namelist
This PR implements the F1850C5AV1C-03 compset, which has been tuned from the F1850C5AV1C-02 compset to give RESTOM approximately zero.
Following are the tuning changes from F1850C5AV1C-02:
Defaults for
zmconv_dmpdzandzmconv_mx_bot_lyr_adjwere hard-wired to be different for L30 and L72. These values are now implemented in the use_case namelist default files, so their value is easy to find.Also fixes #754
[BFB]
[NML]
AG-435