-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completion of F1850C5AV1C-03 Compset #893
Conversation
The PR (#889) for F1850C5AV1C-03 was pushed to master before the configuration had been finalized. This commit implements the changes for the chosen configuration (vc10): clubb_gamma_coef = 0.29 seasalt_emis_scale = 1.05 [FCC, NML] [AG-435]
NOTE: The PR for the preliminary implementation of this compset is #889 |
@golaz, do you want us to change the 1850-L configuration from -02 to -03 in this PR, or wait until the 2000 v-03 is ready? |
I am going to merge this PR to next. If we need to make further changes to this PR, I will merge it again to next. |
Completion of F1850C5AV1C-03 Compset The PR (#889) for F1850C5AV1C-03 was pushed to master before the configuration had been finalized. This commit implements the changes for the chosen configuration (vc10): clubb_gamma_coef = 0.29 seasalt_emis_scale = 1.05 [NML] [AG-435] [BFB] * cameronsmith1/atm/F1850C5AV1C-03b: Completion of F1850C5AV1C-03 Bugfix for default call to compute_tms even if do_tms is not true
@cameronsmith1 : I would prefer to change the 1850-L and 2000-L to point to -03 rather than -02 together at the same time to avoid any possible confusion. |
As this PR doesn't need any new change, I am going to merge it to master. This will make 1850-03 compset to be identical to vc10_1850 experiment (please see https://acme-climate.atlassian.net/wiki/display/ATM/Assessment+of+F1850+Tuning+Simulations for details about vc10_1850 experiment) |
Completion of F1850C5AV1C-03 Compset The PR (#889) for F1850C5AV1C-03 was pushed to master before the configuration had been finalized. This commit implements the changes for the chosen configuration (vc10): clubb_gamma_coef = 0.29 seasalt_emis_scale = 1.05 [NML] [AG-435] [BFB] * cameronsmith1/atm/F1850C5AV1C-03b: Completion of F1850C5AV1C-03
For the record, there is a small difference between this configuration and the vc10_1850 simulation run by @polunma , which inadvertently used the old DMS emission file. When the vc10 parameters were selected, this small difference was accounted for in the selection process. |
Thanks @cameronsmith1 ! |
WARNING: This is fixed in PR #896 |
Repoint AV1C-L compsets from AV1C-02 to AV1C-03 (for 1850 & 2000) The AV1C-L compsets were created to point to the latest version of the AV1C compsets. With the implementation of the AV1C-03 compsets for both 1850 and 2000 (PR #893 , PR #895), this current PR is to shift AV1C-L from the -02 compsets to the -03 compsets. [non-BFB] [NML] AG-435 * cameronsmith1/atm/AV1C-03-L_compset: Repoint AV1C-L compsets from AV1C-02 to AV1C-03 (for 1850 & 2000).
Repoint AV1C-L compsets from AV1C-02 to AV1C-03 (for 1850 & 2000) The AV1C-L compsets were created to point to the latest version of the AV1C compsets. With the implementation of the AV1C-03 compsets for both 1850 and 2000 (PR #893 , PR #895), this current PR is to shift AV1C-L from the -02 compsets to the -03 compsets. [non-BFB] [NML] AG-435 * cameronsmith1/atm/AV1C-03-L_compset: Repoint AV1C-L compsets from AV1C-02 to AV1C-03 (for 1850 & 2000).
…nent Print time built per model Test suite: code_checker Test baseline: Test namelist changes: Test status: bit for bit Fixes #893 User interface changes?: Output time per built component Code review: @jedwards4b
Repoint AV1C-L compsets from AV1C-02 to AV1C-03 (for 1850 & 2000) The AV1C-L compsets were created to point to the latest version of the AV1C compsets. With the implementation of the AV1C-03 compsets for both 1850 and 2000 (PR #893 , PR #895), this current PR is to shift AV1C-L from the -02 compsets to the -03 compsets. [non-BFB] [NML] AG-435 * cameronsmith1/atm/AV1C-03-L_compset: Repoint AV1C-L compsets from AV1C-02 to AV1C-03 (for 1850 & 2000).
The PR (#889) for F1850C5AV1C-03 was pushed to master before the configuration had been finalized. This commit implements the changes for the chosen configuration (vc10):
clubb_gamma_coef = 0.29
seasalt_emis_scale = 1.05
[NML] [AG-435]
WARNING (bug found after this PR was pushed to master): clubb_gamma_coef was accidentally specified twice in the use_case file (1850_cam5_av1c-03.xml), and the wrong number (0.32) ended up in atm_in. Now provides the correct value (0.29). This is fixed in PR #896.