-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global map plots #34
Conversation
596741a
to
01f2195
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once all the instances of plot_land
are False, I'm happy to have this merged! Thanks for getting this in! I think this will be so helpful for the hackathon.
@cbegeman, thanks for the review. I started writing documentation for this and felt pretty dissatisfied with the way that remapping is handled (specifically the clunky way that I had to make up a name for the mapping file before knowing things like the output grid resolution). If time permits before the hackathon, I'm going to do some other work first, then come back to this. I'll make sure your review is incorporated. |
01f2195
to
bccd5e7
Compare
Rearrange intersphinx in alphabetical order
bccd5e7
to
7970111
Compare
@cbegeman, okay, just letting you know that I'm going ahead with this one as soon as CI passes. |
This merge adds a new
MappingFileStep
for making mapping files between all the grid types supported bypyremap
.It also adds a function,
plot_global
, for plotting global arrays on a lon-lat grid.Finally, this merge adds
VizMap
andViz
steps to the cosine bell test case to demonstrate the new capabilities. The result are images (with land plotted overtop, though that could easily be removed with a flag to the plotting function) from both the beginning and end of each simulation.Checklist
api.md
) has any new or modified class, method and/or functions listedTesting
comment in the PR documents testing used to verify the changes