Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mapping file step #40

Merged
merged 6 commits into from
Apr 17, 2023
Merged

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Apr 16, 2023

This merge adds the MappingFileStep to the framework. It can be used to create mapping files between various grids and meshes.

The merge also adds an example of its usage to the cosine bell test case. Each MPAS mesh is remapped to a regular lon-lat grid with 0.5 degree resolution (by default -- a config option can be used to change this) using conservative remapping (again, controlled by a config option).

This merge builds off of dependencies, added in #39

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.md) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • Testing comment in the PR documents testing used to verify the changes

@xylar xylar marked this pull request as draft April 16, 2023 21:56
@xylar xylar added enhancement New feature or request framework Changes relating to the polaris framework as opposed to individual tests or analysis ocean Related to ocean tests or analysis labels Apr 16, 2023
@xylar xylar self-assigned this Apr 16, 2023
@xylar
Copy link
Collaborator Author

xylar commented Apr 16, 2023

Testing

This has been tested in conjunction with #39 and #34. The new VizMap and Viz steps run as expected on a sequence of resolutions on my laptop (210, 240, 270 and 300 km).

@xylar xylar mentioned this pull request Apr 16, 2023
5 tasks
@xylar xylar added the in progress This PR is not ready for review or merging label Apr 16, 2023
@xylar xylar force-pushed the add-mapping-file-step branch from c06dc2e to 8723025 Compare April 16, 2023 22:01
@xylar xylar marked this pull request as ready for review April 16, 2023 22:02
@xylar xylar removed the in progress This PR is not ready for review or merging label Apr 16, 2023
@xylar xylar requested a review from cbegeman April 16, 2023 22:02
@xylar
Copy link
Collaborator Author

xylar commented Apr 16, 2023

@cbegeman, I pulled this out of #34. I hope there aren't any surprises here. If you wouldn't mind giving it a quick glance when you can, I'd appreciate it. Then, I'll merge and rebase #34 so it can go in cleanly. No need to re-review that one.

Five minutes wasn't enough for the last merge.
Copy link
Collaborator

@cbegeman cbegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xylar I skimmed over the changes. Looks good!

@xylar
Copy link
Collaborator Author

xylar commented Apr 17, 2023

Thanks for taking a look @cbegeman!

@xylar xylar merged commit d57bf01 into E3SM-Project:main Apr 17, 2023
@xylar xylar deleted the add-mapping-file-step branch April 17, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request framework Changes relating to the polaris framework as opposed to individual tests or analysis ocean Related to ocean tests or analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants