Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as Hi-PACE/hipace#541
For best results, use close-by pinning, esp. with MPI, and avoid oversubscription of cores, esp. if no hyperthreading is available:
Close #2036
Add Comment to Avoid Accidental Box Over-Subscription
Traditionally, we use OpenMP for the AMReX
MFIter
-loop over multiple boxes on a rank (and tile/vectorize inside the box).If we want to parallelize the FFT here with OpenMP, we should make sure that specific loop does not use the pragma omp then (thx @RemiLehe for the reminder):
WarpX/Source/FieldSolver/SpectralSolver/SpectralFieldData.cpp
Line 148 in add16de
WarpX/Source/FieldSolver/SpectralSolver/SpectralFieldData.cpp
Line 250 in add16de
Test with
WarpX/Regression/WarpX-tests.ini
Lines 369 to 386 in add16de