CMake: FFTW Search w/ CMake Install #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
bug
ax3l
changed the title
ax3l
force-pushed
the
fix-fftwOMPwithCMake
branch
2 times, most recently
from
974eacd to
56766d4
Compare
ax3l
changed the title
This adds support for FFTW search with OpenMP support if FFTW was installed with CMake. This is, for instance, the case with EasyBuild based installs on Juelich's JUWELS Booster cluster. Fixes: - the FFTW install does NOT define CMake targets for their sub- targets, so we need to manually find and link the `_omp` lib - the library dir hint with CMake was empty because of a differing spelling (upper vs lowercase of FFTW from pkg-config check module) Tested: - installed with pkg-config, SP and DP, picked up with `*.pc` - installed with CMake, SP and DP, picked up with `*config.cmake` - installed with CMake, SP and DP, picked up with `*.pc`
ax3l
force-pushed
the
fix-fftwOMPwithCMake
branch
from
56766d4 to
0203275
Compare
EZoni
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for FFTW search with OpenMP support if FFTW was installed with CMake. This is, for instance, the case with EasyBuild based installs on Juelich's JUWELS Booster cluster.
Fixes:
_omplibTested:
*.pc*config.cmake*.pcSystem check:
pkg-configmodule setfftw3${HFFTWp}_LIBRARY_DIRSis unset on JUWELS (butfftw3${HFFTWp}_PREFIXis setFollow-up to #2040
Same as Hi-PACE/hipace#553