-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up hypre dependency install #244
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@junghans I can't quite figure out how to get the downstream package to use
|
junghans
reviewed
Jun 4, 2020
Co-authored-by: Christoph Junghans <junghans@lanl.gov>
junghans
reviewed
Jun 4, 2020
junghans
approved these changes
Jun 4, 2020
2d0469d
to
85a5dd6
Compare
streeve
reviewed
Jun 4, 2020
junghans
reviewed
Jun 4, 2020
junghans
reviewed
Jun 4, 2020
junghans
approved these changes
Jun 4, 2020
streeve
approved these changes
Jun 4, 2020
Travis isn't reporting back but the downstream testing for external packages is breaking in some builds:
I'm surprised ArborX isn't getting picked up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hypre dependency was not being correctly installed so downstream packages would have had to included hypre in their
CMAKE_PREFIX_PATH
even though it is an implementation detail in Cajita. This PR adds proper install for this.