Enable generation of a 2D neighbor list using ArborX #248
Conversation
…r in the custom callback
…hierarchy from ArborX
| predicates ); | ||
|
|
||
| Kokkos::View<int *, DeviceType> counts( "counts", n_queries ); | ||
| bvh.query( |
There was a problem hiding this comment.
OK so you do your own 2-pass here - do you force ArborX to do the queries in 1-pass mode so this is effectively still just a 2-pass process as you are filling your own data structure?
There was a problem hiding this comment.
I guess you must check if there is enough space allocated by the user but you never fill the native data structure so ArborX will always do 1-pass because the internal count never goes past 0?
There was a problem hiding this comment.
Correct. We detect that you never called the output functor and do a single pass. Note that we are working on adding a new BVH::query() overload that does only takes the callback (no offsets and values).
| assert( n < numNeighbor( crs_graph, p ) ); | ||
| p -= crs_graph.shift; | ||
| return crs_graph.col_ind( crs_graph.row_ptr( p ) + n ); | ||
| } | ||
| }; | ||
|
|
||
| template <typename MemorySpace, typename Tag> | ||
| class NeighborList<Experimental::Dense<MemorySpace, Tag>> |
There was a problem hiding this comment.
I like this Dense type name
No description provided.