Badge count fails to update upon navigating to homepage/new tab page

[FudgeFury]

Please look at the attached screenshots.

I have noticed that when I go into a website and then back to my default FireFox homepage, the tracker icon number bade does not update. If I open a new tab (I.E. start fresh), it goes back to its default state.

[ghostwords]

Hello and thanks for the report! Just to be clear, this is all using the same tab in the same window, right? I can reproduce now in both Firefox and Chrome. Navigating back in history to the new tab page does not update the badge. Navigating back to a non-new tab page does seem to update the badge.

[FudgeFury]

Hello, Yes, this is using the same tab in the same window. However I am not navigating back but instead pressing the home button beside the browser refresh. I'm glad to be able to help in any way. This extension is slowly becoming my favourite

…

________________________________ From: Alexei <notifications@github.com> Sent: 25 July 2019 17:47 To: EFForg/privacybadger <privacybadger@noreply.github.com> Cc: FudgeFury <MosaDawas@outlook.com>; Author <author@noreply.github.com> Subject: Re: [EFForg/privacybadger] Icon number not updating (#2423) Hello and thanks for the report! Just to be clear, this is all using the same tab in the same window, right? I can reproduce now in both Firefox and Chrome. Navigating back in history to the new tab page does not update the badge. Navigating back to a non-new tab page does seem to update the badge. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#2423?email_source=notifications&email_token=AE4KMRZCVNQLYXC24U5UFM3QBHKKJA5CNFSM4IG4OGSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD22BW6Q#issuecomment-515119994>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AE4KMR6XCA3PGR32Y3CBG4LQBHKKJANCNFSM4IG4OGSA>.

[ghostwords]

Looks like tracker data shown in the popup (which comes from the tabData object) doesn't get updated either. So the underlying issue is probably that we reset tabData for a tab upon an onBeforeRequest event for the "main_frame" of the page, but we don't get this event for new tab pages (I think ... needs confirmation). This seems related to #1997/#2198.

[FudgeFury]

I'm not too good with developing so forgive my simple responses. Will there be a solution for it?

…

________________________________ From: Alexei <notifications@github.com> Sent: Thursday, July 25, 2019 5:57:25 PM To: EFForg/privacybadger <privacybadger@noreply.github.com> Cc: FudgeFury <MosaDawas@outlook.com>; Author <author@noreply.github.com> Subject: Re: [EFForg/privacybadger] Badge count fails to update upon navigating to homepage/new tab page (#2423) Looks like tracker data shown in the popup (which comes from the tabData object) doesn't get updated either. So the underlying issue is probably that we reset tabData for a tab upon an onBeforeRequest event for the "main_frame" of the page, but we don't get this event for new tab pages (I think ... needs confirmation). This seems related to #1997<#1997>/#2198<https://github.com/EFForg/privacybadger/pull/2198>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#2423?email_source=notifications&email_token=AE4KMR6E3GEADLASHPLFJW3QBHLPLA5CNFSM4IG4OGSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD22CUTI#issuecomment-515123789>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AE4KMR6VMH2NKCRUSDRJVNDQBHLPLANCNFSM4IG4OGSA>.

[ghostwords]

Sure, once a Privacy Badger developer or a volunteer gets to working on this bug.

[ghostwords]

@ablanathtanalba We should probably fix this with a chrome.webNavigation listener that takes care of updating tab data.

The underlying problem here is that the way we reset tab data now (chrome.webRequest.onBeforeRequest with type "main_frame") doesn't happen sometimes (when there is no actual Web request: going to an about:/chrome: page, returning to a Service Worker page that returns cached data, ...).

On the other hand, chrome.webNavigation should always fire upon navigation. One question is whether we will still need tab data resetting upon onBeforeRequest/"main_frame", but we should be able to answer that experimentally.