Misattribution fixes #2198
Closed
Misattribution fixes #2198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostwords
force-pushed
the
misattribution-fixes
branch
from
2d0fd4a to
ccc9133
Compare
ghostwords
force-pushed
the
misattribution-fixes
branch
from
ccc9133 to
123797c
Compare
By checking the request's document URL when available.
ghostwords
force-pushed
the
misattribution-fixes
branch
2 times, most recently
from
a9aaca2 to
11c8da7
Compare
By checking the request's document URL when available.
ghostwords
force-pushed
the
misattribution-fixes
branch
2 times, most recently
from
211de76 to
021299e
Compare
Service worker requests seem to be the only case where details.documentUrl contains a non-trivial path. This needs to be confirmed.
ghostwords
force-pushed
the
misattribution-fixes
branch
from
021299e to
fdead71
Compare
Conflicts: src/js/webrequest.js
Conflicts: src/js/webrequest.js
|
Ghostery's Service Workers/beacons-workaround: ghostery/ghostery-extension#382 (comment) |
This comment has been minimized.
This comment has been minimized.
|
Should be able to remove cleanup from badger-sett after this gets merged and we have a few badger-sett runs to confirm that's the case. |
Conflicts: src/js/heuristicblocking.js src/js/webrequest.js
Conflicts: src/js/webrequest.js
Conflicts: src/js/heuristicblocking.js src/js/utils.js src/js/webrequest.js
When looking for misattribution. Avoids computing hosts/origins when there is no misattribution. Could matter when there is misattribution across different subdomains (and we care about URLs such as with cookie sharing detection).
Following up on fdead71
As misattribution doesn't necessarily mean we are on a different site now (missing "main_frame" web workers bug); we could just be getting requests from the previous site we were on (rapid navigation/ping bugs).
As details.initiator is not a complete URL.
Conflicts: src/js/heuristicblocking.js src/js/utils.js
ghostwords
force-pushed
the
misattribution-fixes
branch
from
8923fe9 to
d3fe4f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes most of #1997
and maybe some of #1144. Fixes #2692.Should be followed up by #2024.