Fix issues with google link unwrapping #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cleaning links, don't remove 'about', 'class', or 'aria-*' attributes. Fixes #2181.
|
Is it worth adding the same exceptions to the hangouts/docs comment unwrapping? |
|
Sure, may avoid breakage in the future. |
ghostwords
reviewed
Oct 4, 2018
Apply same exceptions when stripping attributes from static Google link shims in hangouts and google docs.
bcyphers
force-pushed
the
google-link-quickfix
branch
from
3c82189 to
8a191bd
Compare
ghostwords
added a commit
that referenced
this pull request
Oct 4, 2018
Fix style problems and the "open results in new browser windows" setting on Google Search.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cleaning links, don't remove 'about', 'class', or 'aria-*' attributes. Fixes #2181.