Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Google search result image/video thumbnails #2476

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Fix Google search result image/video thumbnails #2476

merged 1 commit into from
Oct 8, 2019

Conversation

ghostwords
Copy link
Member

By ignoring "style" attributes on links.

Previously: #2182.

@ghostwords
Fix Google search result image/video thumbnails.
30d105e 
By ignoring "style" attributes on links.
@ghostwords ghostwords added the first-party relating to first-party scripts label Oct 8, 2019
ablanathtanalba
ablanathtanalba approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@ablanathtanalba ablanathtanalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to recreate this bug with a fresh make runff instance, then lo and behold, these changes fix it! Great work

bcyphers
bcyphers approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@bcyphers bcyphers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me

ghostwords added a commit that referenced this pull request Oct 8, 2019
@ghostwords
Merge pull request #2476.
c940268 
Fix Google search result image/video thumbnails.
@ghostwords ghostwords merged commit 30d105e into master Oct 8, 2019
@ghostwords ghostwords deleted the fix-google-search-previews branch October 8, 2019 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcyphers bcyphers bcyphers approved these changes

@ablanathtanalba ablanathtanalba ablanathtanalba approved these changes

Assignees
No one assigned
Labels
first-party relating to first-party scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghostwords @bcyphers @ablanathtanalba