Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain datatype when listing literals from rdflib #163

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Retain datatype when listing literals from rdflib #163

merged 3 commits into from
Jan 11, 2024

Conversation

jesper-friis
Copy link
Contributor

@jesper-friis jesper-friis commented Jan 2, 2024 •
edited
Loading

Description

Closes #162

Type of change:

  • Bug fix and code cleanup.
  • New feature.
  • Documentation update.
  • Testing.

Checklist for the reviewer:

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@jesper-friis jesper-friis linked an issue Jan 2, 2024 that may be closed by this pull request
Literals are lost when listing triples with rdflib #162
Closed
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ba94108) 75.17% compared to head (3302157) 75.21%.

Files Patch % Lines
tripper/mappings/mappings.py 0.00% 1 Missing ⚠️
tripper/utils.py 85.71% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   75.17%   75.21%   +0.03%     
==========================================
  Files          17       17              
  Lines        1410     1416       +6     
==========================================
+ Hits         1060     1065       +5     
- Misses        350      351       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesper-friis jesper-friis mentioned this pull request Jan 3, 2024
Merged
9 tasks
ajeklund
ajeklund reviewed Jan 9, 2024
View reviewed changes
Copy link
Contributor

@ajeklund ajeklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I added a couple of questions.

tripper/mappings/mappings.py Show resolved Hide resolved
tripper/utils.py Outdated Show resolved Hide resolved
tripper/utils.py Show resolved Hide resolved
@jesper-friis jesper-friis requested a review from ajeklund January 10, 2024 09:50
ajeklund
ajeklund approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@ajeklund ajeklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@jesper-friis jesper-friis merged commit 11fa3dc into master Jan 11, 2024
14 checks passed
@jesper-friis jesper-friis deleted the 162-lost-rdflib-literals branch January 11, 2024 20:36
jesper-friis added a commit that referenced this pull request Jan 26, 2024
@jesper-friis
Improved comparing literals (#164)
ef0eead 
# Description:
Improved literal equality comparisons. They now compare as expected. 

Note, this PR builds on top of PR #163

Closes #161 

## Type of change:
<!-- Put an `x` in the box that applies. -->
- [ ] Bug fix and code cleanup.
- [x] New feature.
- [ ] Documentation update.
- [ ] Testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajeklund ajeklund ajeklund approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Literals are lost when listing triples with rdflib
3 participants
@jesper-friis @codecov-commenter @ajeklund