Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved comparing literals #164

Merged
merged 19 commits into from
Jan 26, 2024
Merged

Improved comparing literals #164

merged 19 commits into from
Jan 26, 2024

Conversation

jesper-friis
Copy link
Contributor

@jesper-friis jesper-friis commented Jan 3, 2024

Description:

Improved literal equality comparisons. They now compare as expected.

Note, this PR builds on top of PR #163

Closes #161

Type of change:

  • Bug fix and code cleanup.
  • New feature.
  • Documentation update.
  • Testing.

Checklist for the reviewer:

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@jesper-friis jesper-friis linked an issue Jan 3, 2024 that may be closed by this pull request
@jesper-friis jesper-friis changed the base branch from master to 162-lost-rdflib-literals January 3, 2024 15:52
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

Attention: Patch coverage is 82.89474% with 13 lines in your changes missing coverage. Please review.

Project coverage is 75.94%. Comparing base (11f37ba) to head (666cf63).
Report is 178 commits behind head on master.

Files with missing lines Patch % Lines
tripper/triplestore.py 44.44% 10 Missing ⚠️
tripper/literal.py 93.18% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
- Coverage   76.05%   75.94%   -0.12%     
==========================================
  Files          17       17              
  Lines        1491     1534      +43     
==========================================
+ Hits         1134     1165      +31     
- Misses        357      369      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from 162-lost-rdflib-literals to master January 11, 2024 20:36
Copy link
Contributor

@ajeklund ajeklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have provided a couple of questions.

tests/test_literals.py Outdated Show resolved Hide resolved
tests/test_literals.py Show resolved Hide resolved
tripper/literal.py Outdated Show resolved Hide resolved
@jesper-friis jesper-friis requested a review from ajeklund January 26, 2024 00:05
Copy link
Contributor

@ajeklund ajeklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to clarify one of my comments., and added a new one.

tests/test_collection.py Outdated Show resolved Hide resolved
tests/test_literals.py Show resolved Hide resolved
Co-authored-by: Anders Eklund <96499163+ajeklund@users.noreply.github.com>
@jesper-friis jesper-friis requested a review from ajeklund January 26, 2024 13:18
jesper-friis and others added 2 commits January 26, 2024 14:51
Co-authored-by: Anders Eklund <96499163+ajeklund@users.noreply.github.com>
Copy link
Contributor

@ajeklund ajeklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for fixing this!

tests/test_literals.py Show resolved Hide resolved
@jesper-friis jesper-friis merged commit ef0eead into master Jan 26, 2024
14 checks passed
@jesper-friis jesper-friis deleted the 161-literal-equality branch January 26, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Surprising literal comparisons
3 participants