-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved comparing literals #164
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #164 +/- ##
==========================================
- Coverage 76.05% 75.94% -0.12%
==========================================
Files 17 17
Lines 1491 1534 +43
==========================================
+ Hits 1134 1165 +31
- Misses 357 369 +12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I have provided a couple of questions.
Co-authored-by: Anders Eklund <96499163+ajeklund@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to clarify one of my comments., and added a new one.
Co-authored-by: Anders Eklund <96499163+ajeklund@users.noreply.github.com>
Co-authored-by: Anders Eklund <96499163+ajeklund@users.noreply.github.com>
own interpretation of Literal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you for fixing this!
Description:
Improved literal equality comparisons. They now compare as expected.
Note, this PR builds on top of PR #163
Closes #161
Type of change:
Checklist for the reviewer:
This checklist should be used as a help for the reviewer.