net_plugin reduce signed_block copies #6397

heifner · 2018-11-27T18:57:27Z

Change Description

Made signed_block copy constructor private so the compiler will prevent accidental copies of signed_block
Updated net_plugin to avoid unneeded signed_block copies

Consensus Changes

None

API Changes

net_plugin message format did NOT change.

Documentation Additions

None

…rom net_message

plugins/net_plugin/net_plugin.cpp

plugins/chain_plugin/include/eosio/chain_plugin/chain_plugin.hpp

plugins/chain_plugin/chain_plugin.cpp

plugins/net_plugin/net_plugin.cpp

heifner added 6 commits November 27, 2018 13:43

Make signed_block copy constructor private to avoid accidental copies.

bb72d47

move signed_block instead of making copy

f1d16f2

Avoid copy constructor for push_block

dfe8f77

Add which comment

b230172

Update tests for private signed_block copy constructor

6b18a1b

Avoid making copies of signed_block

a4a9ded

heifner changed the title ~~[WIP do not merge] net_plugin reduce signed_block copies~~ net_plugin reduce signed_block copies Nov 27, 2018

heifner added 3 commits November 27, 2018 16:29

Use rvalue for signed_block

0213c88

Special case msg_handler visit of signed_block to avoid hidden move f…

26bf33b

…rom net_message

pass along trigger_send

3d99414

arhag suggested changes Nov 27, 2018

View reviewed changes

Use move for rvalue

07deed1

arhag approved these changes Nov 28, 2018

View reviewed changes

heifner merged commit 760f2b4 into develop Nov 28, 2018

heifner deleted the blk-copy branch November 28, 2018 02:22

Provide feedback