[Feature] Add RoF2 Guild features #3699
Conversation
|
FWIW - I have been running this code for months? now and its current state is very stable and the functionality is much appreciated by players. Thank you so much Neckkola! |
|
Any chance you know how to fix mail to guild? It dies after something like 50 members. |
|
@noudess I will certainly take a look a see. |
|
Left some comments, |
There was a problem hiding this comment.
For comments on using zone spawn packets instead of the appearance updates on client connection: if it's too difficult to change these now it could be done in a followup if you don't want to tackle it but it would probably significantly reduce packets on client connections for guild updates. From only looking at it I'm not sure if it would be an easy switch or not.
Add show guild tag to default spawn process
Removed several unused functions as a result Updated MemberRankUpdate to properly update guild_show on rank change. Updated OP_GuildURLAndChannel opcode for UF/RoF2
|
@hg Thanks for the comments regarding zone spawns. I had a look and have utilized that functionality to remove the specific sendappearance packets. This has allowed for several functions to be removed. Please let me know if you see anything else. Once ok, I will rerun my tests. |
|
Nothing else jumps out with the zone packet stuff so I think you're good to run tests there after fixing the The only other major issues left I think are the world comments (mainly the possible Outside of those the only concern would be some of the db queries that occur in loops instead of being batched for outside, but I'm not sure if those are low frequency updates or not. |
Created function for repetitive zonelist sendpackets to only booted zones Re-Inserted accidental delete of scanclosemobs
|
Good morning @hgtw I have reviewed the world comments and believe I have them updated to resolve the comments and re-inserted the drop scanmobs item. Apologize for that oversight. Also repaired a few other items that I saw, and updated all the remaining strcpy items and left some notes for the db loop items. @Kinglykrab I believe I have the formatting items resolved as well. Anything further, please let me know as I may have overlooked something. |
|
Awesome. I will do some testing on my end. Would welcome others doing the same given the size and scope of the changes. |
Removed a duplicate db call Fixed a fallthrough issue
|
I ran through several test cases between RoF2, UF and TI. Found a few items along the way. |
There was a problem hiding this comment.
Looks good to me, think it's good to go. Will let @Akkadius take another once over if he wants.
|
Do the db changes need to be pushed to peq_content? |
Does this mean people need db changes if we dont use currect pew content? |
Added these on PEQ |
This is done |
Good afternoon.
Over the past several months I have been working on adding the RoF2 Guild Features. While it still requires some spit and polish, I believe it is ready for review. I need to clean it up, rewrite some functions, so please be gentle. :-)
I did not re-write everything as I tried to use the existing guild code as-is. That said, happy to update as you see fit, particularly using the new patterns and repositories. I learned a lot from my last PR that needs to be implemented here. I don't want to wait any longer though, so thought I would push it today.
This adds the following guild features and design pattern the existing guild system;
-- Server no longer sends a guild member list on each zone
-- Guild window is updated when a member levels, rank changes, zone changes, banker/alt status using individual opcodes
-- When a member is removed or added to a guild, a single opcode is sent to each guild member
-- This reduces network traffic considerably
Known issues:
There are database changes that rewrite the guild_members structure and DATA, so please only use in a testing environment. There is also a sql required to update the guild tribute items. This is not within source and is posted here. It creates several items using id 150000 and above so if you have items in that range, use caution. Suggest a test db as well, or a backup before hand.
GuildTributes_2023_09_13_Complete.zip
You will also notice a few #guild test commands. These were/are for my testing and will be removed once the PR is finalized.
There are also a few updates to the world api for testing purposes. These too will be removed.
And finally, the lua protocol opcode item is also fixed, again for my testing purposes.
This code has been working in a few environments for several months, therefore the functionality has been tested. That said, please post any issues and I will look to resolve them. Appreciate any testing that you can do.
For the devs, thanks in advance for taking a look at this and I hope it helps the community.
Neckkola.