Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add RoF2 Guild features #3699

Merged
merged 78 commits into from
Feb 10, 2024
Merged

[Feature] Add RoF2 Guild features #3699

merged 78 commits into from
Feb 10, 2024

Commits on Dec 28, 2023

  1. [Feature] Add additional Guild Features 

    This adds the following guild features and design pattern
- the existing guild system was used
- guild features are based on RoF2 within source with translaters used to converted between client differences
- backward compatible with Ti and UF, and allows for mixed client servers
- Guild Back for Ti and UF is based on RoF2 Permissions for banking if Guild Leader does not use Ti/UF
- Guild Ranks and Permissions are enabled.
- Guild Tributes are enabled.
- Event logging via rules for donating tribute items and plat
- Rules to limit Guild Tributes based on max level of server
- Rewrote guild communications to client using specific opcodes
-- Server no longer sends a guild member list on each zone
-- Guild window is updated when a member levels, rank changes, zone changes, banker/alt status using individual opcodes
-- When a member is removed or added to a guild, a single opcode is sent to each guild member
-- This reduces network traffic considerably

Known issues:
- Visual bug only. Guild Tributes window will display a 0 for level if tribute is above max level rule setting.
- Visual bug only. Guild Mgmt Window will not display an online member if the player has 'show offline' unchecked and a guild member zones within the Notes/Tribute tab.  This is resolved by selecting and de-selecting the 'Show Offline' checkbox.
    @neckkola @Akkadius
    neckkola authored and Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    b51f08e View commit details
    Browse the repository at this point in the history

  2. Updated RoF2 Guild Comms 

    Updated RoF2 Guild Comms
Update RoF2 Opcodes
Rewrote RoF2 Guild Communications using specific opcodes.
Added database changes - they are irreversible
    @neckkola @Akkadius
    neckkola authored and Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    6b6ebe9 View commit details
    Browse the repository at this point in the history

  3. Formatting

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    936c262 View commit details
    Browse the repository at this point in the history

  4. Update base_guild_members_repository.h

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    153ab09 View commit details
    Browse the repository at this point in the history

  5. Format GuildInfo

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    c69d25e View commit details
    Browse the repository at this point in the history

  6. Format GuildAction enum

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    9912b59 View commit details
    Browse the repository at this point in the history

  7. Formatting in clientlist

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    6bad8df View commit details
    Browse the repository at this point in the history

  8. quantity vs quantity

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    be0fbd6 View commit details
    Browse the repository at this point in the history

  9. desc vs description

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    efdf665 View commit details
    Browse the repository at this point in the history

  10. Format structs

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    2e1b654 View commit details
    Browse the repository at this point in the history

  11. Inline struct values

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    b8d84b0 View commit details
    Browse the repository at this point in the history

  12. Formatting

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    8cc10b4 View commit details
    Browse the repository at this point in the history

  13. Formatting

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    47632ab View commit details
    Browse the repository at this point in the history

  14. Formatting fixes

    @neckkola @Akkadius
    neckkola authored and Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    075e117 View commit details
    Browse the repository at this point in the history

  15. Formatting items

    @neckkola @Akkadius
    neckkola authored and Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    559c731 View commit details
    Browse the repository at this point in the history

  16. Formatting

    @neckkola @Akkadius
    neckkola authored and Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    aaf27b4 View commit details
    Browse the repository at this point in the history

  17. Formatting

    @neckkola @Akkadius
    neckkola authored and Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    3b89b58 View commit details
    Browse the repository at this point in the history

  18. struct formatting updates

    @neckkola @Akkadius
    neckkola authored and Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    a02d38a View commit details
    Browse the repository at this point in the history

  19. Updated formatting

    @neckkola @Akkadius
    neckkola authored and Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    f317155 View commit details
    Browse the repository at this point in the history

  20. Updated 

    - std:string items
- naming conventions
- magic numbers
    @neckkola @Akkadius
    neckkola authored and Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    e3df77d View commit details
    Browse the repository at this point in the history

  21. Repo refactors 

    Other formatting updates
    @neckkola @Akkadius
    neckkola authored and Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    1fe4697 View commit details
    Browse the repository at this point in the history

  22. Remove test guild commands

    @neckkola @Akkadius
    neckkola authored and Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    a120e2b View commit details
    Browse the repository at this point in the history

  23. Updated #guild info command

    @neckkola @Akkadius
    neckkola authored and Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    ce25564 View commit details
    Browse the repository at this point in the history

  24. Add new repo methods for Neckolla ReplaceOne and ReplaceMany

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    1174a7c View commit details
    Browse the repository at this point in the history

  25. Fix guild_tributes repo

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    be6978d View commit details
    Browse the repository at this point in the history

  26. Update database_update_manifest.cpp

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    27fba61 View commit details
    Browse the repository at this point in the history

  27. Phase 1 of final testing with RoF2 -> RoF2. 

    Next phase will be inter compatibility review
    @neckkola @Akkadius
    neckkola authored and Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    77dc8a1 View commit details
    Browse the repository at this point in the history

  28. Remove #guild testing commands

    @neckkola @Akkadius
    neckkola authored and Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    19c1e02 View commit details
    Browse the repository at this point in the history

  29. Fix uf translator error 

    Rewrite LoadGuilds
    @neckkola @Akkadius
    neckkola authored and Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    3ba8543 View commit details
    Browse the repository at this point in the history

  30. Use extended repository

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    7215ce1 View commit details
    Browse the repository at this point in the history

  31. FIx guild window on member add

    @neckkola @Akkadius
    neckkola authored and Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    e980ae0 View commit details
    Browse the repository at this point in the history

  32. LoadGuild Changes

    @neckkola @Akkadius
    neckkola authored and Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    9cd9235 View commit details
    Browse the repository at this point in the history

  33. Update guild_base.cpp

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    f06322c View commit details
    Browse the repository at this point in the history

  34. Few small fixes for display issue with UF

    @neckkola @Akkadius
    neckkola authored and Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    585e0ce View commit details
    Browse the repository at this point in the history

  35. Update guild_base.cpp

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    e72a197 View commit details
    Browse the repository at this point in the history

  36. Update guild_members_repository.h

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    7794044 View commit details
    Browse the repository at this point in the history

  37. Update zoneserver.cpp

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    56b64bf View commit details
    Browse the repository at this point in the history

  38. Update guild.cpp

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    6575513 View commit details
    Browse the repository at this point in the history

  39. Update entity.h

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    00c749c View commit details
    Browse the repository at this point in the history

  40. Switch formatting

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    1d0416e View commit details
    Browse the repository at this point in the history

  41. Formatting

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    585d910 View commit details
    Browse the repository at this point in the history

  42. Update worldserver.cpp

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    c1c372f View commit details
    Browse the repository at this point in the history

  43. Switch formatting

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    429690b View commit details
    Browse the repository at this point in the history

  44. Formatting switch statement

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    d3d31be View commit details
    Browse the repository at this point in the history

  45. Update guild.cpp

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    0b44f7c View commit details
    Browse the repository at this point in the history

  46. Formatting in guild_base

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    8929f03 View commit details
    Browse the repository at this point in the history

  47. We don't need to validate m_db everywhere

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    377e83e View commit details
    Browse the repository at this point in the history

  48. More formatting / spacing issues

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    75e85e5 View commit details
    Browse the repository at this point in the history

  49. Switch format

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    d9b2365 View commit details
    Browse the repository at this point in the history

  50. Update guild_base.cpp

    @Akkadius
    Akkadius committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    1a32833 View commit details
    Browse the repository at this point in the history

  51. Fix an UF issue displaying incorrect guildtag as <>

    @neckkola
    neckkola committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    386ba73 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2023

  1. Updated several constants, fixed a few issues with Ti/UF and guild tr… 

    …ibutes not being removed or sent when a member is removed/disbands from a guild.
    @neckkola
    neckkola committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    96c979f View commit details
    Browse the repository at this point in the history

  2. Formatting and logging updates

    @neckkola
    neckkola committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    272bad4 View commit details
    Browse the repository at this point in the history

  3. Fix for Loadguilds and permissions after repo updates.

    @neckkola
    neckkola committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    c532b95 View commit details
    Browse the repository at this point in the history

  4. Cleanup unnecessary m_db checks

    @neckkola
    neckkola committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    75a9d07 View commit details
    Browse the repository at this point in the history

  5. Updated logging to use player_event_logs

    @neckkola
    neckkola committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    6aa9f53 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Updated to use the single opcodes for guild traffic for Ti/UF/RoF2. S… 

    …everal enhancements for guild functionality for more reusable code and readability.
    @neckkola
    neckkola committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    8a1f7e9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into GuildFeatures

    @neckkola
    neckkola authored Jan 2, 2024
    Configuration menu
    Copy the full SHA
    590f7c2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'GuildFeatures' of https://github.com/neckkola/Server in… 

    …to GuildFeatures
    @neckkola
    neckkola committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    bd6e064 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Update to fix Demote Self and guild invites declining when option set… 

    … to not accept guild invites
    @neckkola
    neckkola committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    a2b939e View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Potential fix for guild notes/tribute display issues when client has … 

    …'Show Offline' unchecked.
    @neckkola
    neckkola committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    0d774bd View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Merge branch 'master' into GuildFeatures

    @neckkola
    neckkola committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    56028aa View commit details
    Browse the repository at this point in the history

  2. Updates to fox recent master changes 

    Updates to fix recent master changes
    @neckkola
    neckkola committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    27b2017 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2024

  1. Updates in response to comments

    @neckkola
    neckkola committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    0f0e310 View commit details
    Browse the repository at this point in the history

  2. Further Updates in response to comments

    @neckkola
    neckkola committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    2edf29f View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2024

  1. Comment updates and refactor for SendAppearance functions

    @neckkola
    neckkola committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    ce01863 View commit details
    Browse the repository at this point in the history

  2. Comment updates

    @neckkola
    neckkola committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    0db0482 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Update client spawn process for show guild name 

    Add show guild tag to default spawn process
    @neckkola
    neckkola committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    4a26284 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Update to use zone spawn packets for RoF2 

    Removed several unused functions as a result
Updated MemberRankUpdate to properly update guild_show on rank change.
Updated OP_GuildURLAndChannel opcode for UF/RoF2
    @neckkola
    neckkola committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    6cb955c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into GuildFeatures

    @neckkola
    neckkola authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    66e672c View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2024

  1. Cleanup of world changes 

    Created function for repetitive zonelist sendpackets to only booted zones
Re-Inserted accidental delete of scanclosemobs
    @neckkola
    neckkola committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    5db06a5 View commit details
    Browse the repository at this point in the history

  2. Fixes

    @neckkola
    neckkola committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    969d8d4 View commit details
    Browse the repository at this point in the history

  3. Further world cleanup

    @neckkola
    neckkola committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    32d9eba View commit details
    Browse the repository at this point in the history

  4. Fix a few test guild bank cases for backward compat 

    Removed a duplicate db call
Fixed a fallthrough issue
    @neckkola
    neckkola committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    9fb6fb5 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Update guild_mgr.cpp

    @Akkadius
    Akkadius committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    cbe8fc9 View commit details
    Browse the repository at this point in the history

  2. Cleanup

    @Akkadius
    Akkadius committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    a3277ee View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into pr/3699

    @Akkadius
    Akkadius committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    a2d5604 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2024

  1. Merge remote-tracking branch 'origin/master' into pr/3699

    @Akkadius
    Akkadius committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    7aebd28 View commit details
    Browse the repository at this point in the history