-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update NUOPC cap and externals to match CAM #262
Conversation
@cacraigucar @peverwhee when reviewing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To find my comments, I did a mixture of xxdiff cam6_3_037 vs cam6_3_161
and xxdiff cam6_3_161 vs your cam-sima fork
.
@@ -83,7 +83,6 @@ module dyn_grid | |||
public :: model_grid_init |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this routine, I see:
use_cslam
was instituted as a replacement forfv_nphys>0
- line 256 no longer had
=thermodynamic_active_species_num+3
, but simply has=3
- at line 400, the GLL grid no longer has the
'area'
attribute, just'np'
and'ne'
fvm_aerawt
andphysgrid_areawt
were added in a number of places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep all of those changes will be coming in with my future SE dycore update PR (as each one of them will require non-trivial changes to the dycore code itself).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving this unresolved, just so I can find it again, but agree to deferring
@@ -83,7 +83,6 @@ module dyn_grid | |||
public :: model_grid_init |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving this unresolved, just so I can find it again, but agree to deferring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small things!
I also think someone recently added a "SHOULD" to the CAM Fortran coding standard to keep use statements at the lowest scope - something to consider.
Thanks @nusbaume !
@peverwhee Just FYI I also did some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @nusbaume !
This PR updates the NUOPC cap to match the version used in cam6_3_160, as well as the externals. Additional clean-up was also performed, including the removal of the now deprecated MCT cap.
Resolves #146
Tests run:
Ran Kessler and Held-Suarez snapshot comparison runs on Derecho with GNU.
Ran official regression tests (
test_driver.sh
) with both GNU and Intel on Derecho.