Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam_cesm2_1_rel_55: SMYLE and LEext compsets for CESM2.1 branch #525

Merged
merged 9 commits into from
Feb 2, 2022

Conversation

cacraigucar
Copy link
Collaborator

Issues:
Closes #511
Closes #164

PRs:
Closes #510
Closes #514

@cacraigucar cacraigucar added the enhancement New feature or request label Feb 2, 2022
@cacraigucar cacraigucar self-assigned this Feb 2, 2022
@cacraigucar cacraigucar changed the title SMYLE and LEext compsets for CESM2.1 branch cam_cesm2_1_rel_55: SMYLE and LEext compsets for CESM2.1 branch Feb 2, 2022
Copy link

@fvitt fvitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay

Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just one optional clean-up request.

Comment on lines 26 to 30
<!-- QBO settings -->
<qbo_use_forcing >.true.</qbo_use_forcing>
<qbo_use_forcing hgrid="0.9x1.25">.false.</qbo_use_forcing>
<qbo_cyclic>.false.</qbo_cyclic>
<qbo_forcing_file>atm/waccm/qbo/qbocoefficients_c151023.nc</qbo_forcing_file>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this section necessary given that qbo_use_forcing is always set to .false. below?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jedwards4b - This question is for you.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not, I've removed it.

Copy link
Collaborator

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question and one ChangeLog tweak but otherwise okay.

<ext_frc_cycle_yr > 2100 </ext_frc_cycle_yr>

<!-- Solar data -->
<solar_irrad_data_file>atm/cam/solar/SolarForcingCMIP6-3.2_18491231-26490629_sumEPP_c20220114.nc </solar_irrad_data_file>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this pathname does not have $INPUTDATA_ROOT?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanr this question is for you.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The root dir does not need to be specified here. Build-namelist will fill it in.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gold2718 - Perhaps @fvitt can answer this, but I can say from experience, that there are some specifiers which require $INPUTDATA_ROOT and some that do not want it. I confirmed that this is one of the latter.

- Add use case to extend the LE run from 2100 through 2500

A bld/namelist_files/use_cases/waccm_sc_smyle_L83.xml
- Add SMYLE 83 level compset
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe:

Suggested change
- Add SMYLE 83 level compset
- Add default runtime values for SMYLE 83 level compset

@cacraigucar cacraigucar merged commit 11d8475 into ESCOMP:cam_cesm2_1_rel Feb 2, 2022
@cacraigucar cacraigucar deleted the cam_cesm2_1_rel_55 branch February 2, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants