-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cam_cesm2_1_rel_55: SMYLE and LEext compsets for CESM2.1 branch #525
cam_cesm2_1_rel_55: SMYLE and LEext compsets for CESM2.1 branch #525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just one optional clean-up request.
<!-- QBO settings --> | ||
<qbo_use_forcing >.true.</qbo_use_forcing> | ||
<qbo_use_forcing hgrid="0.9x1.25">.false.</qbo_use_forcing> | ||
<qbo_cyclic>.false.</qbo_cyclic> | ||
<qbo_forcing_file>atm/waccm/qbo/qbocoefficients_c151023.nc</qbo_forcing_file> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this section necessary given that qbo_use_forcing
is always set to .false.
below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jedwards4b - This question is for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not, I've removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question and one ChangeLog tweak but otherwise okay.
<ext_frc_cycle_yr > 2100 </ext_frc_cycle_yr> | ||
|
||
<!-- Solar data --> | ||
<solar_irrad_data_file>atm/cam/solar/SolarForcingCMIP6-3.2_18491231-26490629_sumEPP_c20220114.nc </solar_irrad_data_file> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this pathname does not have $INPUTDATA_ROOT
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nanr this question is for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The root dir does not need to be specified here. Build-namelist will fill it in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add use case to extend the LE run from 2100 through 2500 | ||
|
||
A bld/namelist_files/use_cases/waccm_sc_smyle_L83.xml | ||
- Add SMYLE 83 level compset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe:
- Add SMYLE 83 level compset | |
- Add default runtime values for SMYLE 83 level compset |
Issues:
Closes #511
Closes #164
PRs:
Closes #510
Closes #514