change glc -> ocn export fields to be glc->rof #100
Merged
+254
−1,097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates for pes and testlist for noresm
Change CISM_USE_ICESHEET to GLC_USE_ICESHEET
…2_1_99 update to cismwrap_2_1_99
update of noresm cism_wrapper to cismwrap_2_1_99
|
@Katetc - not sure how we want to proceed with this - including the review. |
This was referenced Jun 14, 2024
|
@Katetc Do you want to review this - I need it for cesm3_0_alpha02a. |
Yes, I would like to. Thanks! |
Katetc
requested changes
Jun 27, 2024
| call fldlist_add(fldsToGlc_num, fldsToGlc, field_in_tsrf) | ||
| call fldlist_add(fldsToGlc_num, fldsToGlc, field_in_qice) | ||
| call fldlist_add(fldsToGlc_num, fldsToGlc, field_in_so_t_depth, ungridded_lbound=1, ungridded_ubound=nlev_import) | ||
| call fldlist_add(fldsToGlc_num, fldsToGlc, field_in_so_s_depth, ungridded_lbound=1, ungridded_ubound=nlev_import) |
There was a problem hiding this comment.
OK, I think it would make a lot of sense for these ocean-depth fields to be inside of an only "cism evolving" check. But the 2D temperature and surface mass balance should be advertised for both cases.
Katetc
approved these changes
Jun 28, 2024
|
Merged to a temporary branch where I can work out the external tags and write up the ChangeLog before merging to Main. Thanks Mariana! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following