Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMEPS/MOSART/CISM/RTM tags #2590

Closed
ekluzek opened this issue Jun 7, 2024 · 4 comments · Fixed by #2605
Closed

Update CMEPS/MOSART/CISM/RTM tags #2590

ekluzek opened this issue Jun 7, 2024 · 4 comments · Fixed by #2605
Assignees
Labels
enhancement new capability or improved behavior of existing capability PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete science Enhancement to or bug impacting science

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Jun 7, 2024

Update MOSART, CMEPS and CISM so CISM runoff goes to ROF rather than CTSM
Update RTM with fix needed for Paleo LGM work

@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability tag: enh - new science labels Jun 7, 2024
@ekluzek ekluzek added this to the CESM3 Capability Freeze milestone Jun 7, 2024
@ekluzek ekluzek added the blocked: dependency Wait to work on this until dependency is resolved label Jun 7, 2024
@slevis-lmwg slevis-lmwg moved this from Todo to In Progress in LMWG: Near Term Priorities Jun 18, 2024
@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Jun 19, 2024

From meeting with @ekluzek

  • Set separate_glc2ocn_fluxes = .false. and rerun the test-suite: expect bfb to baseline:
    FAIL ./run_sys_tests -s mosart -c mosart1.1.01_ctsm5.2.007 --skip-generate
    Same failure as with separate_glc2ocn_fluxes = .true.
    Update: I checked off this TODO because it is not applicable at this point.
  • Update the submodules tags to the branches: cism runoff will be now routed to ocn via mosart MOSART#94 and the 3 listed here). At this time do not need the ccs_config and rtm updates. The former (ccs_config) is ready so bring in regardless. The latter (rtm) is pending so bring in when it's time to merge to master. Update: At this point the ccs_config and the rtm PRs are ready, so I'm bringing them in.
  • Update .gitmodules temporarily: url (my own) and tag (try the branch name or may have to point to the hash on my fork).
  • Open PR for my ctsm branch from master.
  • @ekluzek will review cism runoff will be now routed to ocn via mosart MOSART#94 to discuss possible code changes and likely need for cdeps
  • Make a branch tag for this branch (same process as we followed for the ctsm5.2 branch, see naming convention, branch_tags/cismtorof.n01_ctsm5.2.007)
  • Add 2 new tests to the mosart test-suite:
    Start with ERS_Ld5.f10_f10_mg37.I2000Clm60BgcCru.derecho_gnu.mosart-default both using cism compsets, one setting separate_glc2ocn_fluxes = .false. in its tesmod directory and the other using the default (so no testmod needed).
    Update: This namelist option has been removed, so I will now add only 1 new test to include cism in the compset.
  • Run the mosart test-suite and generate baseline mosart1.1.02_ctsm5.2.007:
    derecho and izumi OK: NLCOMP and "field lists differ"
    derecho sanity check OK: ./run_sys_tests -s rtm -c rtm1_0_80_ctsm5.2.007 --skip-generate NLCOMP only
  • Run aux_clm to make sure running with cism works and generate baseline cismtorof.n01_ctsm5.2.007
    derecho and izumi OK: NLCOMP and "field lists differ" BUT ALSO DIFF from baseline for expected vars (e.g. TWS, *volr, *volrmch, *rofl)
  • Make the mosart tag and the rtm tag:
    cism runoff will be now routed to ocn via mosart MOSART#94 mosart1.1.02
    fix area scaling to correct RTM river flux to MOM6 RTM#51 rtm1_0_80
  • @jedwards4b makes tags:
    Implementation of glc->ocn coupling via going through mosart  CMEPS#463 cmeps0.14.67
    removal of mapping files that are no longer needed for cism->mosart ESMCI/ccs_config_cesm#174 ccs_config_cesm0.0.110
  • @Katetc makes the cism tag.
  • Update to the new tags
  • Run ./run_sys_tests -s aux_clm -c cismtorof.n01_ctsm5.2.007 --skip-generate
    Run ./run_sys_tests -s ctsm_sci -c ctsm_sci-ctsm5.2.007 --skip-generate
  • Results and waiting for feedback in Update submodule tags to pass runoff from CISM to ROF as per issue #2590 #2605 (comment)
  • Repeat testing with the latest master tag, merge the PR, and tag as normal.

@slevis-lmwg
Copy link
Contributor

@ekluzek our first TODO with separate_glc2ocn_fluxes = .false. failed the same way as separate_glc2ocn_fluxes = .true. so this may need to be part of your code review and conversation with Mariana.

@slevis-lmwg
Copy link
Contributor

In the above TODO list, I just checked off "Make a branch tag" by doing:

git tag -a branch_tags/cismtorof.n01_ctsm5.2.007
git push escomp branch_tags/cismtorof.n01_ctsm5.2.007 

@slevis-lmwg
Copy link
Contributor

@slevis-lmwg slevis-lmwg moved this from In Progress to Stalled in LMWG: Near Term Priorities Jun 24, 2024
@slevis-lmwg slevis-lmwg moved this from Stalled to In Progress in LMWG: Near Term Priorities Jul 1, 2024
@slevis-lmwg slevis-lmwg moved this from In Progress to Stalled in LMWG: Near Term Priorities Jul 5, 2024
@slevis-lmwg slevis-lmwg moved this from Stalled to Done in LMWG: Near Term Priorities Jul 9, 2024
ekluzek added a commit to ekluzek/CTSM that referenced this issue Jul 11, 2024
ekluzek added a commit to ekluzek/CTSM that referenced this issue Jul 11, 2024
@slevis-lmwg slevis-lmwg added PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete and removed blocked: dependency Wait to work on this until dependency is resolved labels Jul 16, 2024
slevis-lmwg added a commit that referenced this issue Jul 22, 2024
Update submodule tags to pass runoff from CISM to ROF as per issue #2590
glemieux added a commit to rgknox/ctsm that referenced this issue Jul 24, 2024
Update submodule tags to pass runoff from cism to rof

- Update MOSART, CMEPS, and CISM so CISM runoff goes to ROF rather than CTSM
- Update RTM with fix needed for Paleo LGM work

Contributors:
@mvertens, @jedwards4b, @billsacks, @Katetc, @ekluzek, @slevis-lmwg

 Fixes ESCOMP#2590 Update CMEPS/MOSART/CISM/RTM tags
 Fixes ESCOMP/RTM#50 Likely wrong RTM river flux to MOM6 within cesm2_3_beta17

 Differences in namelist 'mosart_inparm':
  missing variable: 'do_rtmflood'
  missing variable: 'finidat_rtm'
  missing variable: 'frivinp_rtm'
  missing variable: 'rtmhist_fexcl1'
  missing variable: 'rtmhist_fexcl2'
  missing variable: 'rtmhist_fexcl3'
  missing variable: 'rtmhist_fincl1'
  missing variable: 'rtmhist_fincl2'
  missing variable: 'rtmhist_fincl3'
  missing variable: 'rtmhist_mfilt'
  missing variable: 'rtmhist_ndens'
  missing variable: 'rtmhist_nhtfrq'
  found extra variable: 'budget_frq'
  found extra variable: 'fexcl1'
  found extra variable: 'fexcl2'
  found extra variable: 'fexcl3'
  found extra variable: 'fincl1'
  found extra variable: 'fincl2'
  found extra variable: 'fincl3'
  found extra variable: 'finidat'
  found extra variable: 'frivinp'
  found extra variable: 'mfilt'
  found extra variable: 'mosart_euler_calc'
  found extra variable: 'mosart_tracers'
  found extra variable: 'ndens'
  found extra variable: 'nhtfrq'
  found extra variable: 'use_halo_option'

Changes answers
- what code configurations: mosart and rtm
- what platforms/compilers: all
- nature of change: mosart roundoff; rtm larger than roundoff due to bug fix; the latter also affects bgc variables

 We are ignoring strange diffs from baseline in two tests in variable
 FATES_TRANSITION_MATRIX_LULU as explained in issue ESCOMP#2656.
ekluzek added a commit to ekluzek/CTSM that referenced this issue Jul 24, 2024
Update submodule tags to pass runoff from cism to rof

- Update MOSART, CMEPS, and CISM so CISM runoff goes to ROF rather than CTSM
- Update RTM with fix needed for Paleo LGM work

Contributors:
@mvertens, @jedwards4b, @billsacks, @Katetc, @ekluzek, @slevis-lmwg

 Fixes ESCOMP#2590 Update CMEPS/MOSART/CISM/RTM tags
 Fixes ESCOMP/RTM#50 Likely wrong RTM river flux to MOM6 within cesm2_3_beta17

 Differences in namelist 'mosart_inparm':
  missing variable: 'do_rtmflood'
  missing variable: 'finidat_rtm'
  missing variable: 'frivinp_rtm'
  missing variable: 'rtmhist_fexcl1'
  missing variable: 'rtmhist_fexcl2'
  missing variable: 'rtmhist_fexcl3'
  missing variable: 'rtmhist_fincl1'
  missing variable: 'rtmhist_fincl2'
  missing variable: 'rtmhist_fincl3'
  missing variable: 'rtmhist_mfilt'
  missing variable: 'rtmhist_ndens'
  missing variable: 'rtmhist_nhtfrq'
  found extra variable: 'budget_frq'
  found extra variable: 'fexcl1'
  found extra variable: 'fexcl2'
  found extra variable: 'fexcl3'
  found extra variable: 'fincl1'
  found extra variable: 'fincl2'
  found extra variable: 'fincl3'
  found extra variable: 'finidat'
  found extra variable: 'frivinp'
  found extra variable: 'mfilt'
  found extra variable: 'mosart_euler_calc'
  found extra variable: 'mosart_tracers'
  found extra variable: 'ndens'
  found extra variable: 'nhtfrq'
  found extra variable: 'use_halo_option'

Changes answers
- what code configurations: mosart and rtm
- what platforms/compilers: all
- nature of change: mosart roundoff; rtm larger than roundoff due to bug fix; the latter also affects bgc variables

 We are ignoring strange diffs from baseline in two tests in variable
 FATES_TRANSITION_MATRIX_LULU as explained in issue ESCOMP#2656.

 Conflicts:
	bld/unit_testers/build-namelist_test.pl
slevis-lmwg added a commit to slevis-lmwg/ctsm that referenced this issue Jul 24, 2024
Update submodule tags to pass runoff from cism to rof

- Update MOSART, CMEPS, and CISM so CISM runoff goes to ROF rather than CTSM
- Update RTM with fix needed for Paleo LGM work

Contributors:
@mvertens, @jedwards4b, @billsacks, @Katetc, @ekluzek, @slevis-lmwg

 Fixes ESCOMP#2590 Update CMEPS/MOSART/CISM/RTM tags
 Fixes ESCOMP/RTM#50 Likely wrong RTM river flux to MOM6 within cesm2_3_beta17

 Differences in namelist 'mosart_inparm':
  missing variable: 'do_rtmflood'
  missing variable: 'finidat_rtm'
  missing variable: 'frivinp_rtm'
  missing variable: 'rtmhist_fexcl1'
  missing variable: 'rtmhist_fexcl2'
  missing variable: 'rtmhist_fexcl3'
  missing variable: 'rtmhist_fincl1'
  missing variable: 'rtmhist_fincl2'
  missing variable: 'rtmhist_fincl3'
  missing variable: 'rtmhist_mfilt'
  missing variable: 'rtmhist_ndens'
  missing variable: 'rtmhist_nhtfrq'
  found extra variable: 'budget_frq'
  found extra variable: 'fexcl1'
  found extra variable: 'fexcl2'
  found extra variable: 'fexcl3'
  found extra variable: 'fincl1'
  found extra variable: 'fincl2'
  found extra variable: 'fincl3'
  found extra variable: 'finidat'
  found extra variable: 'frivinp'
  found extra variable: 'mfilt'
  found extra variable: 'mosart_euler_calc'
  found extra variable: 'mosart_tracers'
  found extra variable: 'ndens'
  found extra variable: 'nhtfrq'
  found extra variable: 'use_halo_option'

Changes answers
- what code configurations: mosart and rtm
- what platforms/compilers: all
- nature of change: mosart roundoff; rtm larger than roundoff due to bug fix; the latter also affects bgc variables

 We are ignoring strange diffs from baseline in two tests in variable
 FATES_TRANSITION_MATRIX_LULU as explained in issue ESCOMP#2656.
samsrabin added a commit to samsrabin/CTSM that referenced this issue Jul 25, 2024
Update submodule tags to pass runoff from cism to rof

- Update MOSART, CMEPS, and CISM so CISM runoff goes to ROF rather than CTSM
- Update RTM with fix needed for Paleo LGM work

Contributors:
@mvertens, @jedwards4b, @billsacks, @Katetc, @ekluzek, @slevis-lmwg

 Fixes ESCOMP#2590 Update CMEPS/MOSART/CISM/RTM tags
 Fixes ESCOMP/RTM#50 Likely wrong RTM river flux to MOM6 within cesm2_3_beta17

 Differences in namelist 'mosart_inparm':
  missing variable: 'do_rtmflood'
  missing variable: 'finidat_rtm'
  missing variable: 'frivinp_rtm'
  missing variable: 'rtmhist_fexcl1'
  missing variable: 'rtmhist_fexcl2'
  missing variable: 'rtmhist_fexcl3'
  missing variable: 'rtmhist_fincl1'
  missing variable: 'rtmhist_fincl2'
  missing variable: 'rtmhist_fincl3'
  missing variable: 'rtmhist_mfilt'
  missing variable: 'rtmhist_ndens'
  missing variable: 'rtmhist_nhtfrq'
  found extra variable: 'budget_frq'
  found extra variable: 'fexcl1'
  found extra variable: 'fexcl2'
  found extra variable: 'fexcl3'
  found extra variable: 'fincl1'
  found extra variable: 'fincl2'
  found extra variable: 'fincl3'
  found extra variable: 'finidat'
  found extra variable: 'frivinp'
  found extra variable: 'mfilt'
  found extra variable: 'mosart_euler_calc'
  found extra variable: 'mosart_tracers'
  found extra variable: 'ndens'
  found extra variable: 'nhtfrq'
  found extra variable: 'use_halo_option'

Changes answers
- what code configurations: mosart and rtm
- what platforms/compilers: all
- nature of change: mosart roundoff; rtm larger than roundoff due to bug fix; the latter also affects bgc variables

 We are ignoring strange diffs from baseline in two tests in variable
 FATES_TRANSITION_MATRIX_LULU as explained in issue ESCOMP#2656.
adrifoster pushed a commit to adrifoster/CTSM that referenced this issue Jul 25, 2024
Update submodule tags to pass runoff from cism to rof

- Update MOSART, CMEPS, and CISM so CISM runoff goes to ROF rather than CTSM
- Update RTM with fix needed for Paleo LGM work

Contributors:
@mvertens, @jedwards4b, @billsacks, @Katetc, @ekluzek, @slevis-lmwg

 Fixes ESCOMP#2590 Update CMEPS/MOSART/CISM/RTM tags
 Fixes ESCOMP/RTM#50 Likely wrong RTM river flux to MOM6 within cesm2_3_beta17

 Differences in namelist 'mosart_inparm':
  missing variable: 'do_rtmflood'
  missing variable: 'finidat_rtm'
  missing variable: 'frivinp_rtm'
  missing variable: 'rtmhist_fexcl1'
  missing variable: 'rtmhist_fexcl2'
  missing variable: 'rtmhist_fexcl3'
  missing variable: 'rtmhist_fincl1'
  missing variable: 'rtmhist_fincl2'
  missing variable: 'rtmhist_fincl3'
  missing variable: 'rtmhist_mfilt'
  missing variable: 'rtmhist_ndens'
  missing variable: 'rtmhist_nhtfrq'
  found extra variable: 'budget_frq'
  found extra variable: 'fexcl1'
  found extra variable: 'fexcl2'
  found extra variable: 'fexcl3'
  found extra variable: 'fincl1'
  found extra variable: 'fincl2'
  found extra variable: 'fincl3'
  found extra variable: 'finidat'
  found extra variable: 'frivinp'
  found extra variable: 'mfilt'
  found extra variable: 'mosart_euler_calc'
  found extra variable: 'mosart_tracers'
  found extra variable: 'ndens'
  found extra variable: 'nhtfrq'
  found extra variable: 'use_halo_option'

Changes answers
- what code configurations: mosart and rtm
- what platforms/compilers: all
- nature of change: mosart roundoff; rtm larger than roundoff due to bug fix; the latter also affects bgc variables

 We are ignoring strange diffs from baseline in two tests in variable
 FATES_TRANSITION_MATRIX_LULU as explained in issue ESCOMP#2656.
adrifoster pushed a commit to adrifoster/CTSM that referenced this issue Jul 25, 2024
Update submodule tags to pass runoff from cism to rof

- Update MOSART, CMEPS, and CISM so CISM runoff goes to ROF rather than CTSM
- Update RTM with fix needed for Paleo LGM work

Contributors:
@mvertens, @jedwards4b, @billsacks, @Katetc, @ekluzek, @slevis-lmwg

 Fixes ESCOMP#2590 Update CMEPS/MOSART/CISM/RTM tags
 Fixes ESCOMP/RTM#50 Likely wrong RTM river flux to MOM6 within cesm2_3_beta17

 Differences in namelist 'mosart_inparm':
  missing variable: 'do_rtmflood'
  missing variable: 'finidat_rtm'
  missing variable: 'frivinp_rtm'
  missing variable: 'rtmhist_fexcl1'
  missing variable: 'rtmhist_fexcl2'
  missing variable: 'rtmhist_fexcl3'
  missing variable: 'rtmhist_fincl1'
  missing variable: 'rtmhist_fincl2'
  missing variable: 'rtmhist_fincl3'
  missing variable: 'rtmhist_mfilt'
  missing variable: 'rtmhist_ndens'
  missing variable: 'rtmhist_nhtfrq'
  found extra variable: 'budget_frq'
  found extra variable: 'fexcl1'
  found extra variable: 'fexcl2'
  found extra variable: 'fexcl3'
  found extra variable: 'fincl1'
  found extra variable: 'fincl2'
  found extra variable: 'fincl3'
  found extra variable: 'finidat'
  found extra variable: 'frivinp'
  found extra variable: 'mfilt'
  found extra variable: 'mosart_euler_calc'
  found extra variable: 'mosart_tracers'
  found extra variable: 'ndens'
  found extra variable: 'nhtfrq'
  found extra variable: 'use_halo_option'

Changes answers
- what code configurations: mosart and rtm
- what platforms/compilers: all
- nature of change: mosart roundoff; rtm larger than roundoff due to bug fix; the latter also affects bgc variables

 We are ignoring strange diffs from baseline in two tests in variable
 FATES_TRANSITION_MATRIX_LULU as explained in issue ESCOMP#2656.
@samsrabin samsrabin added the science Enhancement to or bug impacting science label Aug 8, 2024
@ekluzek ekluzek moved this to Done (non release/external) in CTSM: Upcoming tags Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete science Enhancement to or bug impacting science
Projects
Status: Done (non release/external)
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants