Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fates_allom_smode shell_command update in FatesColdHydro testmod #2878

Closed
glemieux opened this issue Nov 13, 2024 · 0 comments · Fixed by #2882 or #2928
Closed

Remove fates_allom_smode shell_command update in FatesColdHydro testmod #2878

glemieux opened this issue Nov 13, 2024 · 0 comments · Fixed by #2882 or #2928
Assignees
@glemieux
Labels
FATES A change needed for FATES that doesn't require a FATES API update. test: fates Pass fates test suite before merging testing additions or changes to tests

Comments

@glemieux
Copy link
Collaborator

glemieux commented Nov 13, 2024 •
edited
Loading

This issue requires that NGEET/fates#1268 has been integrated on the fates-side. This should be easily accomplished with a git revert of f2f7535.
@glemieux glemieux self-assigned this Nov 13, 2024
@glemieux glemieux added FATES A change needed for FATES that doesn't require a FATES API update. testing additions or changes to tests test: fates Pass fates test suite before merging labels Nov 13, 2024
This was referenced Nov 13, 2024
Merged
Merged
@slevis-lmwg slevis-lmwg mentioned this issue Jan 9, 2025
Merged
slevis-lmwg added a commit to slevis-lmwg/ctsm that referenced this issue Jan 9, 2025
@slevis-lmwg
Merge tag 'ctsm5.3.017' into hist_time_mid_of_time_bounds
ffeb713 
Merge tmp-241219 branch to master

Includes three tmp-241219 tags:

tmp-241219.n01.ctsm5.3.016 Merge b4b-dev:
nfix_method options Houlton (default), Bytnerowicz (option)
tmp-241219.n02.ctsm5.3.016 FATES hydro test update
tmp-241219.n03.ctsm5.3.016 Bug fix for izumi nag tests to pass (b4b unless using Bytnerowicz)

Fixes ESCOMP#2924 Fix problem with izumi nag tests
Fixes ESCOMP#2878 Remove fates_allom_smode shell_command update in FatesColdHydro testmod
Fixes ESCOMP#2869 Update temperature cost function for symbiotic nfix in FUN

Changes answers as documented in the ChangeLog.

slevis resolved conflicts:
doc/ChangeLog
doc/ChangeSum
ekluzek added a commit to ekluzek/CTSM that referenced this issue Jan 13, 2025
@ekluzek
Merge tag 'ctsm5.3.017' into b4b-dev
b867a3e 
Merge tmp-241219 branch to master

Includes three tmp-241219 tags:

tmp-241219.n01.ctsm5.3.016 Merge b4b-dev:
nfix_method options Houlton (default), Bytnerowicz (option)
tmp-241219.n02.ctsm5.3.016 FATES hydro test update
tmp-241219.n03.ctsm5.3.016 Bug fix for izumi nag tests to pass (b4b unless using Bytnerowicz)

Fixes ESCOMP#2924 Fix problem with izumi nag tests
Fixes ESCOMP#2878 Remove fates_allom_smode shell_command update in FatesColdHydro testmod
Fixes ESCOMP#2869 Update temperature cost function for symbiotic nfix in FUN

Changes answers as documented in the ChangeLog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glemieux glemieux

Labels
FATES A change needed for FATES that doesn't require a FATES API update. test: fates Pass fates test suite before merging testing additions or changes to tests
Projects
None yet
Milestone
No milestone
1 participant
@glemieux