Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

landuse_timeseries_text_files may stomp on each other when making all surface datasets #40

Closed
billsacks opened this issue Dec 16, 2017 · 1 comment
Closed

landuse_timeseries_text_files may stomp on each other when making all surface datasets #40

billsacks opened this issue Dec 16, 2017 · 1 comment
Labels
bug something is working incorrectly closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix

Comments

@billsacks
Copy link
Member

Bill Sacks < sacks@ucar.edu > - 2016-01-26 20:25:09 -0700
Bugzilla Id: 2274
Bugzilla CC: andre@ucar.edu, rfisher@ucar.edu,

About a year ago, Ben made some changes to the file names in mksurfdata.pl so that multiple runs wouldn't stomp on each other. However, it looks like the $landuse_timeseries_text_file (set by write_transient_timeseries_file) could have the same file name in multiple runs. From a quick look, I'm guessing that two files with identical names would have the same contents. If that's true, then this is only a problem if you get unlucky in terms of timing: one process is trying to read the file just as another is in the midst of rewriting it, so that the file is incomplete for the read.

The solution could be to add more qualifiers to the name of this file, so that it is unique - similarly to what is done for the other files. (I'm reworking this code significantly in a branch that I'm about to bring to the trunk.) It just isn't totally straightforward to do this, because of the existing logic for this file name.
@billsacks billsacks added this to the future milestone Dec 16, 2017
@billsacks billsacks added enhancement new capability or improved behavior of existing capability bug something is working incorrectly and removed enhancement new capability or improved behavior of existing capability labels Feb 9, 2018
@billsacks billsacks removed this from the future milestone Nov 5, 2018
@billsacks billsacks added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Jul 8, 2019
@billsacks
Copy link
Member Author

I'm tempted to close this as a wontfix. Let's discuss.

@billsacks billsacks added closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix and removed next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Jul 8, 2019
MiCurry pushed a commit to MiCurry/CTSM that referenced this issue Sep 16, 2021
@dabail10
Merge pull request ESCOMP#40 from ESCOMP/mvertens/scol
7aa3e46 
Introduction of new single column functionality
samsrabin pushed a commit to samsrabin/CTSM that referenced this issue Apr 19, 2024
@uturuncoglu
Merge pull request ESCOMP#40 from hafs-community/feature/hafs_cdeps_pr
3b1ec5a 
Updating CDEPS CMake build system to compile with HAFS
jedwards4b added a commit to jedwards4b/ctsm that referenced this issue Jun 2, 2024
@jedwards4b
Merge pull request ESCOMP#40 from ESMCI/fix/change_url
9e5d5f7 
some fixes when modifying url
ekluzek added a commit to ekluzek/CTSM that referenced this issue Jun 3, 2024
@ekluzek
Squashed '.lib/git-fleximod/' changes from a354b05..a34070b
afbdcbf 
a34070b Bump to 0.7.6
9e5d5f7 Merge pull request ESCOMP#40 from ESMCI/fix/change_url
00b7b38 some fixes when modifying url

git-subtree-dir: .lib/git-fleximod
git-subtree-split: a34070b
swensosc pushed a commit to swensosc/ctsm that referenced this issue Jun 5, 2024
@ekluzek
Merge pull request ESCOMP#40 from ekluzek/moretestsmergeprs
95a6bba 
Update README and comments
ekluzek added a commit to ekluzek/CTSM that referenced this issue Jul 11, 2024
@ekluzek
Squashed '.lib/git-fleximod/' changes from a354b05..a60032499
f2e3334 
a60032499 Merge tag 'v0.8.2' into tmp-release
75a0337 Bump to 0.8.2
7136066 Merge pull request ESCOMP#54 from ESMCI/fix/tag-not-found
a90de4f update to fetch tag first
a6e43fc Bump to 0.8.1
229ba03 Merge pull request ESCOMP#53 from ESMCI/fix/ssh_access
e9cd2be better fix for issue with ssh access
c624b61 Bump to 0.8.0
6ccf617 Merge pull request ESCOMP#51 from ESMCI/fix/recursive
53fce57 no need to make submodule objects persist
dae1c82 now working with issue ESCOMP#50
ded91fd all tests passing, issue ESCOMP#50 fixed
62a338b all pytests now passing
143abac tests a-d all pass
2b021fd add documentation to submodule.py
72211d2 add the new submodule class
82dd7a4 test_b_update now working
a7d8b4e all pytests passing
5322019 Bump to 0.7.9
1f07cb6 Merge pull request ESCOMP#49 from ESMCI/fix/fxDONOTUSEurl
31ce71b use poetry update to update poetry.lock file
46043f0 add code of conduct (issue ESCOMP#35)
0c3d683 dependabot changes and issue ESCOMP#48
25ccc15de Merge tag 'v0.7.8' into tmp-release
8eae7e3 Bump to 0.7.8
34daa06 Merge pull request ESCOMP#46 from ESMCI/add_optional_keyword
af12c80 fix spelling
7ea36dc remove manage_externals error
2ede182 add optional to status output
4ff1e98de Merge tag 'v0.7.7' into tmp-release
87640ad Bump to 0.7.7
c124dc5 Merge pull request ESCOMP#43 from ESMCI/fix/root_dir
3ff935b update tests
0593149 one more improvement
d95f5d6 fix status issue
c304487 update complex test
a34070b Bump to 0.7.6
9e5d5f7 Merge pull request ESCOMP#40 from ESMCI/fix/change_url
00b7b38 some fixes when modifying url

git-subtree-dir: .lib/git-fleximod
git-subtree-split: a600324993623cba8e663fcbfdb6a0f6832dd802
AGonzalezNicolas pushed a commit to HPSCTerrSys/clm5_0 that referenced this issue Jul 25, 2024
@mvhulten
Refactor to modify x2l instead of atm2lnd (ESCOMP#40)
b882524 
Key commits:

* 4412a644 Made oas_receive_icon() to set x2l, not atm2lnd_inst
* 4412a644 Supress exception arising from x2l refactoring
* 941f550a Include clm_cpl_indices module only when coupled to ICON

Co-authored-by: Marco van Hulten <Marco.van.Hulten@uni-bonn.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something is working incorrectly closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@billsacks